Repository navigation
ja: fix the symbol names that Open JTalk misreads, and U+23E6 that stopped the speech - #1068
Open
yasumorishima wants to merge 1 commit into
Open
yasumorishima wants to merge 1 commit into
yasumorishima wants to merge 1 commit into
Conversation
…opped the speech Found by speaking the zh-cn tests' symbols in ja: ベンゼン環, 魚の尾, 凹辺, 太 before a noun, 小文字 after a space, 小なり形/大なり形, 白すみ, 白羽根, 真直度 and 開いた辺 were misread. U+23E6 had spell: "ac", the XPath for a child element, so the expression failed; it is 交流. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxieePCjMFcCuuczCmhyB3
Contributor
Linux library size: 0.60 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spoke the new zh-cn test expressions (#1056) with the ja rules and had Open JTalk read the output, as in the earlier sweeps. Sixty-one names in ja/unicode-full.yaml came out misread: 環 in ベンゼン環 was read タマキ, 魚の尾 ギョノオ, 凹辺 オーベ, 太 before a noun フトシ (as a given name), 小文字 after a space コモンジ, 形 after 小なり and 大なり カタチ, 白 before すみ ハク and before 羽根 シラ, 真直度 マッスグタビ, and 辺 after 開いた アタリ. They are now written so they read as intended (ベンゼンかん, さかなの尾, おうへん, 太い, こもじ, 小なりがた, 白い, しんちょく度, 開いたへん); where the kanji itself is what gets misread it is written in kana, as 行 already is in ぎょう. I checked each against en and marked them T:. ⏦ (U+23E6) also kept the whole expression from being spoken in ja, because spell: "ac" is the XPath for a child element named ac rather than the string 'ac'; it is now 交流, the Japanese word for AC. The same spell: "ac" is in en, de, fr, pt and zh-tw and fails there too, but I left those files alone here. A new test covers one name from each group and ⏦. All tests pass, and audit-translations ja shows 63 fewer untranslated strings with the other counts unchanged.