Repository navigation
ja: read inj lim and proj lim as 帰納極限 and 射影極限, like the limit - #1063
Merged
Merged
Conversation
inj lim and proj lim kept their English names and were read like any other script (inj lim 付き i 下 オブ, おおもじ エー 下付き i). They are now read like a limit, the name and then what is under it: 帰納極限 i; おおもじ エー 下付き i. Adds a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxieeSTvVWiY21XVJUsA5b
Contributor
Linux library size: 0.60 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inj lim and proj lim (\injlim, \projlim) kept their English names in ja and were read like any other script, so inj lim with i under it applied to A_i came out as inj lim 付き i 下 オブ, おおもじ エー 下付き i, and with a subscript as proj lim 下付き i; オブ, おおもじ エー 下付き i. This reads them the way the limit is already read: the Japanese name 帰納極限 or 射影極限, then what is under them, and no オブ for the U+2061 after them (帰納極限 i; おおもじ エー 下付き i). These are the usual Japanese terms for the inductive and projective limit, and Open JTalk reads them as キノーキョクゲン and シャエーキョクゲン. The MathJax output has U+2006 between the words and needs #1062 as well; with only this change the name is read right there but the オブ stays. A new test covers the munder and msub forms. All tests pass, and audit-translations ja shows three more extra rules (the ones added here) with the other counts unchanged.