Repository navigation
ja: read lim sup and lim inf as じょう極限 and か極限, like the limit - #1060
Merged
Merged
Conversation
The limit rule in Intent/general.yaml names lim sup and lim inf limit-sup and limit-inf, but ja only defined lim-sup and lim-inf, so lim sup (n→∞) a_n was read "limit sup n 右向き矢印 無限大; オブ エー 下付き n". ja definitions now has limit-sup and limit-inf as pl does, and the ja conditions for →, ↗, ↘ and U+2061 that looked only at m:limit also take limit-sup and limit-inf, so it reads "じょう極限 n 近づく 無限大; エー 下付き n". じょう and か are written in kana because Open JTalk reads 上極限 as ウエキョクゲン and 下極限 as シモキョクゲン. lim-sup and lim-inf get the same words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxieeSNJ9rQRp9RZet92V9
Contributor
Linux library size: 0.60 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lim sup of a_n as n goes to infinity was read limit sup n 右向き矢印 無限大; オブ エー 下付き n. The limit rule in Intent/general.yaml names lim sup and lim inf limit-sup and limit-inf, but ja only defined lim-sup and lim-inf, so the English intent name was spoken, the arrow was read as a plain 右向き矢印 because the ja arrow rules only look at m:limit, and the オブ of U+2061 stayed because the condition that drops it also only names m:limit. This adds limit-sup and limit-inf to ja/definitions.yaml, as pl has, and lets the ja conditions for →, ↗, ↘ and U+2061 take limit-sup and limit-inf as well, so the example now reads じょう極限 n 近づく 無限大; エー 下付き n, the same shape as the plain limit (極限 n 近づく 無限大; エー 下付き n), and lim inf as x approaches 0 from below reads か極限 x 下から近づく 0; f オブ x. じょう and か are written in kana because Open JTalk reads 上極限 as ウエキョクゲン and 下極限 as シモキョクゲン, and Terse uses the same words instead of リム サップ and リム インフ, as the Terse of the plain limit is 極限. The old lim-sup and lim-inf keys stay and get the same words. Intent and the other languages are not changed. The form MathJax gives for \limsup, an mo with lim, a thin space and sup, now also gets じょう極限 and 近づく but still keeps the オブ, because limsup with a space is not in FunctionNames in Rules/definitions.yaml, so the U+2061 lands in an added mrow; that is outside ja and is left for later. A new test covers lim sup and lim inf in SimpleSpeak, ClearSpeak and Terse. All language tests pass and audit-translations ja is unchanged (the three arrow rules carry an audit-ignore note for the extra condition).