Repository navigation
Conversation
Contributor
Linux library size: 0.60 MiB (-0.02%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
Collaborator
|
Split the line endings -- they are a separate issue. According to AI, the proper way to fix them is to run: |
dkager
force-pushed
the
fix-mo-three-dots-ellipsis
branch
from
November 20, 2026 09:45
ed745f3 to
ead0c7d
Compare
Contributor
Author
Yes, that first command is what I ran. I took that fix out of this branch. It now only touches the ellipsis. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Still working on the Dedicon math notation (#231), and finding more fun curiosities along the way. Dedicon uses three dots
...to indicate blanks. This is canonicalized to…and then Dedicon's Unicode rules grab it and turn it back into....To thoroughly test this I added various notations on my
nlbranch.<mo>...</mo>is rewritten to…, but the check that turns…into anmistill sees the old text, so the element stays anmo. The operators next to it then lose their operand spacing:gives
3+... = 5instead of3 + ... = 5(e.g. in braille codes that space a binary+).Fix
Rename
<mo>...</mo>tomitogether with the rewrite to…, as already happens for<mo>…</mo>.One detail: under
mover,...is still left alone (stays<mo>...</mo>). Note that<mo>…</mo>undermoverdoes become<mi>…</mi>. @NSoiffer is that difference intended? The new tests document the current behavior.One more thing
I sneaked in a fix for a line-ending merge problem. Let me know if I should split that off.