Skip to content

Treat <mo>...</mo> as an ellipsis operand - #1055

Open
dkager wants to merge 1 commit into
daisy:mainfrom
dkager:fix-mo-three-dots-ellipsis
Open

dkager wants to merge 1 commit into
daisy:mainfrom
dkager:fix-mo-three-dots-ellipsis

Conversation

@dkager

@dkager dkager commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Problem

Still working on the Dedicon math notation (#231), and finding more fun curiosities along the way. Dedicon uses three dots ... to indicate blanks. This is canonicalized to … and then Dedicon's Unicode rules grab it and turn it back into ....

To thoroughly test this I added various notations on my nl branch. <mo>...</mo> is rewritten to …, but the check that turns … into an mi still sees the old text, so the element stays an mo. The operators next to it then lose their operand spacing:

<math><mn>3</mn><mo>+</mo><mo>...</mo><mo>=</mo><mn>5</mn></math>

gives 3+... = 5 instead of 3 + ... = 5 (e.g. in braille codes that space a binary +).

Fix

Rename <mo>...</mo> to mi together with the rewrite to …, as already happens for <mo>…</mo>.

One detail: under mover, ... is still left alone (stays <mo>...</mo>). Note that <mo>…</mo> under mover does become <mi>…</mi>. @NSoiffer is that difference intended? The new tests document the current behavior.

One more thing

I sneaked in a fix for a line-ending merge problem. Let me know if I should split that off.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor
Linux library size: 0.60 MiB (-0.02%)
Revision Release liblibmathcat.so
Base (e382c55) 0.60 MiB (625,032 bytes)
PR (ead0c7d) 0.60 MiB (624,928 bytes)
Change -104 bytes (-0.02%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

@NSoiffer

Copy link
Copy Markdown
Collaborator

Split the line endings -- they are a separate issue.

According to AI, the proper way to fix them is to run:
git add --renormalize .
with a .gitattributes rule like *.yaml text eol=lf), and optionally add that commit hash to a .git-blame-ignore-revs file so GitHub and local git blame skip over it.

@dkager
dkager force-pushed the fix-mo-three-dots-ellipsis branch from ed745f3 to ead0c7d Compare November 20, 2026 09:45
@dkager

dkager commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

According to AI, the proper way to fix them is to run: git add --renormalize . with a .gitattributes rule like *.yaml text eol=lf), and optionally add that commit hash to a .git-blame-ignore-revs file so GitHub and local git blame skip over it.

Yes, that first command is what I ran. I took that fix out of this branch. It now only touches the ellipsis.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants