Repository navigation
Fix link check: use lychee-action instead of npx lychee - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The link-check job runs
npx lychee, but lychee is a Rust binary, not an npm package, so the step fails withnpm error could not determine executable to run. Because the step hascontinue-on-error: true, the job still succeeds, the report file is empty, and the dead-link count falls back to 0. The weekly check has therefore never reported a dead link.Fix
lycheeverse/lychee-action@v2(format: markdown,output: lychee-report.md,fail: false).403in addition to200,429, which avoids false positives from sites behind bot protection.steps.lychee.outputs.exit_codeis non-zero. If lychee fails but no entries can be parsed from the report, the count falls back to 1 so a failure is never reported as clean.workflow_dispatchrun of the link check does not also open a review issue.This matches the maintenance workflow already used in
dailydotdev/awesome-show-hn-alternatives.