Skip to content

Fix link check: use lychee-action instead of npx lychee - #50

Merged
nimrodkra merged 1 commit into
mainfrom
fix/link-check-lychee-action
Nov 15, 2026
Merged

nimrodkra merged 1 commit into
mainfrom
fix/link-check-lychee-action

Conversation

@nimrodkra

Copy link
Copy Markdown
Member

Problem

The link-check job runs npx lychee, but lychee is a Rust binary, not an npm package, so the step fails with npm error could not determine executable to run. Because the step has continue-on-error: true, the job still succeeds, the report file is empty, and the dead-link count falls back to 0. The weekly check has therefore never reported a dead link.

Fix

  • Run the checker with lycheeverse/lychee-action@v2 (format: markdown, output: lychee-report.md, fail: false).
  • Accept 403 in addition to 200,429, which avoids false positives from sites behind bot protection.
  • Count dead links only when steps.lychee.outputs.exit_code is non-zero. If lychee fails but no entries can be parsed from the report, the count falls back to 1 so a failure is never reported as clean.
  • Restrict the monthly stale-entry review job to its schedule, so a manual workflow_dispatch run of the link check does not also open a review issue.

This matches the maintenance workflow already used in dailydotdev/awesome-show-hn-alternatives.

@nimrodkra
nimrodkra merged commit 1851677 into main Nov 15, 2026
5 checks passed
@nimrodkra
nimrodkra deleted the fix/link-check-lychee-action branch November 15, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant