Skip to content

es bundle, pnpm - #58

Merged
mbostock merged 11 commits into
mainfrom
mbostock/rollup
Nov 3, 2026
Merged

mbostock merged 11 commits into
mainfrom
mbostock/rollup

Conversation

@mbostock

@mbostock mbostock commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

See d3/d3-array#288 for context.

Also fixes the tests, which were already flaky on main under current Node:

  • now() caches the current time until the next frame (setTimeout 17ms in Node), so a test could start with a time cached by the previous test and see elapsed times one frame too large. A root beforeEach in test/setup.js now waits for the cached time to clear.
  • The wake-time tests allow +2ms for the rounded-up timeout delay from round up timeout delay to avoid waking early #61.
  • A root afterEach restores the global setTimeout (which some tests replace), and mocha runs with --exit, so a failing test that leaves an active timer no longer hangs the run.

Also switches the tests from mocha to vitest (keeping node’s assert and it), and ESLint to v10 with a flat config; vitest is v5. Test files run serially (timing-sensitive), and callback-style tests are converted to promises.

🤖 Generated with Claude Code

mbostock and others added 2 commits November 2, 2026 16:21
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mbostock
mbostock removed this pull request from stack #60 November 3, 2026 00:22
mbostock and others added 9 commits November 2, 2026 16:29
The timeout delay is now rounded up (#61), adding up to 2ms to the delays
observed by the wake-time tests. Also restore the global setTimeout after
each test, and pass --exit to mocha so that a failing test that leaves an
active timer doesn't hang the run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mbostock
mbostock merged commit 9791611 into main Nov 3, 2026
1 check passed
@mbostock
mbostock deleted the mbostock/rollup branch November 3, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant