Repository navigation
es bundle, pnpm - #58
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mbostock
force-pushed
the
mbostock/rollup
branch
from
November 3, 2026 00:22
4f5451a to
a5e8fc1
Compare
The timeout delay is now rounded up (#61), adding up to 2ms to the delays observed by the wake-time tests. Also restore the global setTimeout after each test, and pass --exit to mocha so that a failing test that leaves an active timer doesn't hang the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See d3/d3-array#288 for context.
Also fixes the tests, which were already flaky on
mainunder current Node:now()caches the current time until the next frame (setTimeout17ms in Node), so a test could start with a time cached by the previous test and see elapsed times one frame too large. A rootbeforeEachintest/setup.jsnow waits for the cached time to clear.afterEachrestores the globalsetTimeout(which some tests replace), and mocha runs with--exit, so a failing test that leaves an active timer no longer hangs the run.Also switches the tests from mocha to vitest (keeping node’s
assertandit), and ESLint to v10 with a flat config; vitest is v5. Test files run serially (timing-sensitive), and callback-style tests are converted to promises.🤖 Generated with Claude Code