Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/disjoint.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export default function disjoint(values, other) {
let value, done;
while (({value, done} = iterator.next())) {
if (done) break;
if (Object.is(v, value)) return false;
set.add(value);
if (set.has(v)) return false;
}
}
return true;
Expand Down
2 changes: 1 addition & 1 deletion src/superset.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default function superset(values, other) {
if (done) return false;
const ivalue = intern(value);
set.add(ivalue);
if (Object.is(io, ivalue)) break;
if (set.has(io)) break;
}
}
return true;
Expand Down
16 changes: 16 additions & 0 deletions test/disjoint-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,19 @@ function* repeat(...values) {
yield* values;
}
}

it("disjoint(values, other) interns values encountered while advancing the iterator", () => {
assert.strictEqual(disjoint([new Date(0)], [new Date(0)]), false);
for (const values of [[new Date(0)], [Object(1)], [Object("a")]]) {
const other = values.map(value => Object(value.valueOf()));
assert.strictEqual(disjoint(values, other), false);
assert.strictEqual(disjoint(values, [null, ...other]), false);
assert.strictEqual(disjoint(other, values), false);
}
});

it("disjoint(values, other) uses set equality for signed zeros and NaN", () => {
assert.strictEqual(disjoint([-0], [0]), false);
assert.strictEqual(disjoint([0], [-0]), false);
assert.strictEqual(disjoint([NaN], [NaN]), false);
});
9 changes: 9 additions & 0 deletions test/subset-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,12 @@ it("subset(values, other) performs interning", () => {
assert.strictEqual(subset([new Date("2021-01-03"), new Date("2021-01-04")], [new Date("2021-01-02"), new Date("2021-01-03")]), false);
assert.strictEqual(subset([], [new Date("2021-01-01")]), true);
});

it("subset(values, other) uses set equality for signed zeros and NaN", () => {
assert.strictEqual(subset([-0], [0]), true);
assert.strictEqual(subset([0], [-0]), true);
assert.strictEqual(subset([Object(-0)], [0]), true);
assert.strictEqual(subset([0], [Object(-0)]), true);
assert.strictEqual(subset([0, 1], [1, -0]), true);
assert.strictEqual(subset([NaN], [NaN]), true);
});
9 changes: 9 additions & 0 deletions test/superset-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ it("superset(values, other) performs interning", () => {
assert.strictEqual(superset([new Date("2021-01-01")], []), true);
});

it("superset(values, other) uses set equality for signed zeros and NaN", () => {
assert.strictEqual(superset([-0], [0]), true);
assert.strictEqual(superset([0], [-0]), true);
assert.strictEqual(superset([Object(-0)], [0]), true);
assert.strictEqual(superset([0], [Object(-0)]), true);
assert.strictEqual(superset([1, -0], [0, 1]), true);
assert.strictEqual(superset([NaN], [NaN]), true);
});

function* odds() {
for (let i = 1; true; i += 2) {
yield i;
Expand Down