Repository navigation
Merged
Conversation
…m TokenList::combineOperators()) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dmcppcheck
reviewed
Nov 7, 2026
dmcppcheck
left a comment
Contributor
There was a problem hiding this comment.
AI review
I found no problems. The PR is a pure refactoring. The {/} scope tracking and the x&=2 default-parameter heuristic moved out of combineOperators() into two static helpers, updateExecutableScope() and isAnonymousReferenceParameter(). The code was moved without changes. The helpers are called only where the old inline code ran, and the continues happen in the same places. The && short-circuit means the backwards scan still runs only for & outside executable scopes, so performance is the same. simplecpp.h is untouched, so the API stays the same, and the code is valid C++11.
Testing
make -j8 testrunner simplecpp CXXOPTS=-Werrorinpr/: built with no warnings../testrunner: 0 failed (21 skipped, 15 todos).python3 run-tests.py: no failures.python3 -m pytest integration_test.py: 128 passed../selfcheck.sh: exit code 0.- I built
base/and ran both binaries onscratch/a.cpp. It has&=/& =in these places: free function declarations, a declaration with a body, a member declaration in a struct and in a class with a base list, a qualifiedA::B&=inside a namespace, a qualified calla::b(c&=d), an initializerf(a&=b), an assignment at file scope, and nested blocks in a function. The output ofprandbaseis identical (diffis empty), so the behaviour has not changed.
Automated review of acab82a by Claude. The pull request was built and tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.