Fix #15126 FP syntaxError (function try block with override in struct)

.clang-tidy

@@ -18,6 +18,7 @@ Checks: >
         -objc-*,
         -openmp-*,
         -zircon-*,
+        cppcoreguidelines-avoid-const-or-ref-data-members,
         cppcoreguidelines-pro-type-static-cast-downcast,
         cppcoreguidelines-rvalue-reference-param-not-moved,
         google-explicit-constructor,

.github/workflows/codeql-analysis.yml

@@ -42,6 +42,9 @@ jobs:
       uses: github/codeql-action/init@v4
       with:
         languages: ${{ matrix.language }}
+        config: |
+          paths-ignore:
+            - gui/manualtest
 
     - name: Build cppcheck
       if: matrix.language == 'cpp'

addons/threadsafety.py

@@ -91,7 +91,6 @@
     'race:stdin',
     'race:stdout',
     'race:streams',
-    'race:strerror',
     'race:strsignal',
     'race:strtok',
     'race:tmbuf',
@@ -261,7 +260,6 @@
     'siginterrupt',
     'sleep',
     'srand48',
-    'strerror',
     'strsignal',
     'strtok',
     'tmpnam',

cfg/gnu.cfg

@@ -650,7 +650,7 @@
       <not-bool/>
     </arg>
   </function>
-  <!-- https://man7.org/linux/man-pages/man3/mempcpy.3.html-->
+  <!-- https://man7.org/linux/man-pages/man3/wmempcpy.3.html -->
   <!-- wchar_t *wmempcpy(wchar_t *restrict dest, const wchar_t *restrict src, size_t n);-->
   <function name="wmempcpy">
     <returnValue type="wchar_t *"/>
@@ -659,12 +659,12 @@
     <not-overlapping-data ptr1-arg="1" ptr2-arg="2" size-arg="3"/>
     <arg nr="1" direction="out">
       <not-null/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="2" direction="in">
       <not-null/>
       <not-uninit/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="3" direction="in">
       <not-uninit/>

cfg/std.cfg

@@ -3928,7 +3928,7 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
     <arg nr="1">
       <not-null/>
       <not-uninit/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="2" direction="in">
       <not-uninit/>
@@ -3974,12 +3974,12 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
     <arg nr="1" direction="in">
       <not-null/>
       <not-uninit/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="2" direction="in">
       <not-null/>
       <not-uninit/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="3" direction="in">
       <not-uninit/>
@@ -4016,12 +4016,12 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
     <not-overlapping-data ptr1-arg="1" ptr2-arg="2" count-arg="3"/>
     <arg nr="1" direction="out">
       <not-null/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="2" direction="in">
       <not-null/>
       <not-uninit/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="3" direction="in">
       <not-uninit/>
@@ -4081,13 +4081,13 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
     <leak-ignore/>
     <arg nr="1" direction="out">
       <not-null/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="2">
       <!-- TODO: direction? memory could be overwritten -->
       <not-null/>
       <not-uninit/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="3" direction="in">
       <not-uninit/>
@@ -4141,7 +4141,7 @@ The obsolete function 'gets' is called. With 'gets' you'll get a buffer overrun
     <leak-ignore/>
     <arg nr="1" direction="out">
       <not-null/>
-      <minsize type="argvalue" arg="3"/>
+      <minsize type="argvalue" arg="3" baseType="wchar_t"/>
     </arg>
     <arg nr="2" direction="in">
       <not-uninit/>

clang-tidy.md

@@ -138,7 +138,6 @@ Does not improve the readability.
 To be evaluated (need to remove exclusion).
 
 `cppcoreguidelines-missing-std-forward`<br/>
-`cppcoreguidelines-avoid-const-or-ref-data-members`<br/>
 `cppcoreguidelines-macro-usage`<br/>
 `cppcoreguidelines-pro-type-member-init`<br/>
 `cppcoreguidelines-prefer-member-initializer`<br/>

cli/cmdlineparser.h

@@ -56,6 +56,8 @@ class CmdLineParser {
      * @param suppressions Suppressions instance that keeps the suppressions
      */
     CmdLineParser(CmdLineLogger &logger, Settings &settings, Suppressions &suppressions);
+    CmdLineParser(const CmdLineParser &) = delete;
+    CmdLineParser &operator=(const CmdLineParser &) = delete;
 
     enum class Result : std::uint8_t { Success, Exit, Fail };
 
@@ -152,10 +154,10 @@ class CmdLineParser {
 
     void outputFormatOptionMixingError() const;
 
-    CmdLineLogger &mLogger;
+    CmdLineLogger& mLogger;
 
-    Settings &mSettings;
-    Suppressions &mSuppressions;
+    Settings& mSettings;
+    Suppressions& mSuppressions;
 
 protected:
     std::vector<std::string> mPathNames;

cli/processexecutor.cpp

@@ -96,7 +96,7 @@ namespace {
             {
                 if (suppr.isInline)
                     writeToPipe(REPORT_SUPPR_INLINE, suppressionToString(suppr));
-                else if (suppr.checked)
+                else if (suppr.checked && suppr.hash == 0)
                     writeToPipe(REPORT_SUPPR, suppressionToString(suppr));
             }
         }
@@ -172,8 +172,8 @@ namespace {
                 writeToPipeInternal(type, data.c_str(), len);
         }
 
-        const int mWpipe;
-        const bool mDebug;
+        int mWpipe;
+        bool mDebug;
     };
 }
 

gui/checkthread.cpp

@@ -113,13 +113,15 @@ CheckThread::CheckThread(ThreadResult &result, int threadIndex)
 void CheckThread::setSettings(const Settings &settings, std::shared_ptr<Suppressions> supprs)
 {
     mFiles.clear();
+    mFileSettings.clear();
     mSettings = settings; // this is a copy
     mSuppressions = std::move(supprs);
 }
 
-void CheckThread::analyseWholeProgram(const std::list<FileWithDetails> &files, const std::string& ctuInfo)
+void CheckThread::analyseWholeProgram(const std::list<FileWithDetails> &files, const std::list<FileSettings> &fileSettings, const std::string& ctuInfo)
 {
     mFiles = files;
+    mFileSettings = fileSettings;
     mAnalyseWholeProgram = true;
     mCtuInfo = ctuInfo;
     start();
@@ -136,8 +138,9 @@ void CheckThread::run()
         std::string ctuInfo;
         ctuInfo.swap(mCtuInfo);
         qDebug() << "Whole program analysis";
-        cppcheck.analyseWholeProgram(mSettings.buildDir, mFiles, {}, ctuInfo);
+        cppcheck.analyseWholeProgram(mSettings.buildDir, mFiles, mFileSettings, ctuInfo);
         mFiles.clear();
+        mFileSettings.clear();
         emit done();
         return;
     }

gui/checkthread.h

@@ -69,10 +69,11 @@ class CheckThread : public QThread {
 
     /**
      * @brief Run whole program analysis
-     * @param files    All files
-     * @param ctuInfo  Ctu info for addons
+     * @param files         All files
+     * @param fileSettings  All files of the project
+     * @param ctuInfo       Ctu info for addons
      */
-    void analyseWholeProgram(const std::list<FileWithDetails> &files, const std::string& ctuInfo);
+    void analyseWholeProgram(const std::list<FileWithDetails> &files, const std::list<FileSettings> &fileSettings, const std::string& ctuInfo);
 
     void setAddonsAndTools(const QStringList &addonsAndTools) {
         mAddonsAndTools = addonsAndTools;
@@ -153,6 +154,7 @@ class CheckThread : public QThread {
     bool isSuppressed(const SuppressionList::ErrorMessage &errorMessage) const;
 
     std::list<FileWithDetails> mFiles;
+    std::list<FileSettings> mFileSettings;
     bool mAnalyseWholeProgram{};
     std::string mCtuInfo;
     QStringList mAddonsAndTools;