Skip to content

feat: add dark mode support - #310

Open
Xhoenix wants to merge 3 commits into
coreruleset:mainfrom
Xhoenix:add-dark-mode-support
Open

Xhoenix wants to merge 3 commits into
coreruleset:mainfrom
Xhoenix:add-dark-mode-support

Conversation

@Xhoenix

@Xhoenix Xhoenix commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

What

Add Dark Mode support for relearn theme based on user's OS settings

Why

Because Dark Mode

Reference: Adjust to OS Settings

Note: Added another themeVariant in comments that lets the user choose between color modes.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 25b3915b-5811-40d2-8bf8-75aa5c555cdd
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@EsadCetiner EsadCetiner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a blue dark theme?

@Xhoenix Xhoenix linked an issue Nov 5, 2026 that may be closed by this pull request
@Xhoenix

Xhoenix commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

Isn't there a blue dark theme?

This theme is dark blue with a green sidebar.

@EsadCetiner

Copy link
Copy Markdown
Member

@Xhoenix It doesn't match the light theme at all, it's inconsistent. Can you add some custom styling so both light/dark look the same?

@Xhoenix

Xhoenix commented Nov 11, 2026 •

Copy link
Copy Markdown
Member Author

@Xhoenix It doesn't match the light theme at all, it's inconsistent. Can you add some custom styling so both light/dark look the same?

Can you check now? The 'auto' relies on the same theme as 'relearn-light' and 'relearn-dark' so it's consistent. Should we provide more colour options to users in the theme picker dropdown menu of sidebar?

@EsadCetiner

EsadCetiner commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

@Xhoenix Both the light and dark themes are consistent, but there's still plenty of green. The docs page needs to match CRS's branding, it looks unprofessional and amateurish to go from mostly blue in the main site to mostly green in the docs subsite.

Hugo supports adding custom CSS, so you may need to do that to keep the branding consistent.

@Xhoenix

Xhoenix commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Haven't checked the entirety of docs, so probably missed those greens you're mentioning. Going to see if something can be done.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add support for dark mode

2 participants