Repository navigation
docs: add warnings and a use case on false positive management - #247
touchweb-vincent wants to merge 16 commits into
Conversation
|
thanks for your PR - please make a bit more informative comment under the PR. For example, please see this. The two relevant questions are "why" and "what", with one-one sentences. Thank you again. |
|
@airween done, does this sound good to you ? |
airween
left a comment
There was a problem hiding this comment.
I'm not a native English speaker so it's not the best idea to give a review, but I made a suggestion.
Cc: @theseion, @RedXanadu.
Yes, excellent! Thank you! |
Co-authored-by: Ervin Hegedus <airween@gmail.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
|
Please work through the open comments @touchweb-vincent. |
|
@theseion I was waiting for your point of view before committing the changes. The changes have now been committed. |
|
Please mark comments as resolved when you're done with them (two where still unresolved). That helps me, as a reviewer, to know that you've seen every comment. If you decide to not apply a suggestion or act on a comment (which is a valid choice), please provide a reason for why. Otherwise I have to assume you didn't read or understand the comment. |
|
Please resolve the open comments @touchweb-vincent. |
|
@theseion All comments have been marked as resolved here. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Fix formatting issue in rule exclusion example
| **Scenario:** Several different parts of a web application are causing false positives with various SQL injection rules. None of the web services behind the WAF make use of SQL, so it is deemed safe to tune away these false positives by removing all the SQLi detection rules. | ||
|
|
||
| {{% notice warning %}} | ||
| This type of broad exclusion is dangerous and should only be considered if the rules are causing problems _and_ the application is not vulnerable to the specific attack, e.g., the PHP rules cause issues and no application behind the WAF uses PHP. |
There was a problem hiding this comment.
| This type of broad exclusion is dangerous and should only be considered if the rules are causing problems _and_ the application is not vulnerable to the specific attack, e.g., the PHP rules cause issues and no application behind the WAF uses PHP. | |
| This type of broad exclusion is dangerous and should only be considered if the rule is noisy _and_ the application is not vulnerable to the specific attack, e.g. PHP rules are causing many false positives but the application behind the WAF doesn't use PHP. |
Hello,
what
This PR adds explicit warning notices to several rule-exclusion examples and documentation sections.
These notices remind users that:
why
To help users avoid unsafe tuning practices that could compromise the effectiveness of CRS.
Some examples and documentation snippets may look harmless, but when reused without proper context they can lead to overly broad exclusions or rule bypasses.
Adding warnings provides clear guidance about when an example is for demonstration only, and when it should never be used in production.