Skip to content

Update module golang.org/x/crypto to v0.59.0 [SECURITY] (main) - #3694

Open
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main-main/go-golang.org-x-crypto-vulnerability
Open

red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main-main/go-golang.org-x-crypto-vulnerability

Conversation

@red-hat-konflux

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
golang.org/x/crypto v0.57.0 → v0.59.0 age confidence

The golang.org/x/crypto/openpgp package is unmaintained, unsafe by design, and has known security issues

GO-2026-5932

More information

Details

The golang.org/x/crypto/openpgp package is unsafe by design, has numerous known security issues, is not maintained, and should not be used.

If you are required to interoperate with OpenPGP systems and need a maintained package, consider github.com/ProtonMail/go-crypto/openpgp which is a maintained fork that aims to be a drop-in replacement for this package.

Severity

Unknown

References

This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux
red-hat-konflux Bot requested a review from a team as a code owner November 12, 2026 05:38
@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: acceptance/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 6 additional dependencies were updated

Details:

Package Change
golang.org/x/sync v0.23.0 -> v0.25.0
golang.org/x/mod v0.41.0 -> v0.42.0
golang.org/x/net v0.58.0 -> v0.62.0
golang.org/x/sys v0.48.0 -> v0.50.0
golang.org/x/term v0.46.0 -> v0.48.0
golang.org/x/text v0.42.0 -> v0.44.0
File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 7 additional dependencies were updated

Details:

Package Change
golang.org/x/net v0.58.0 -> v0.62.0
golang.org/x/sync v0.23.0 -> v0.25.0
golang.org/x/text v0.42.0 -> v0.44.0
golang.org/x/mod v0.41.0 -> v0.42.0
golang.org/x/sys v0.48.0 -> v0.50.0
golang.org/x/term v0.46.0 -> v0.48.0
golang.org/x/tools v0.49.0 -> v0.52.0
File name: tools/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 7 additional dependencies were updated

Details:

Package Change
golang.org/x/mod v0.41.0 -> v0.42.0
golang.org/x/net v0.58.0 -> v0.62.0
golang.org/x/sync v0.23.0 -> v0.25.0
golang.org/x/sys v0.48.0 -> v0.50.0
golang.org/x/term v0.46.0 -> v0.48.0
golang.org/x/text v0.42.0 -> v0.44.0
golang.org/x/tools v0.49.0 -> v0.52.0

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

The root, acceptance, and tools Go module files update golang.org/x dependency versions. Each adds golang.org/x/crypto/openpgp v0.1.0-deprecated.

Changes: Go module dependency updates

Layer / File(s) Summary
Update module requirements
go.mod, acceptance/go.mod, tools/go.mod
The module files update golang.org/x dependency versions. Each adds golang.org/x/crypto/openpgp v0.1.0-deprecated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: simonbaird, robnester-rh, joejstuart

Merge Risk: Minimal · up to b7ea5

This updates golang.org/x dependencies as a security update. No concrete merge-blocking defect was found. The legacy OpenPGP package remains an indirect dependency of the cosign and rekor chain, so it is worth watching upstream, but it does not block this update.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description follows the Renovate-generated format. It gives the package, version change, and a vulnerability advisory (GO-2026-5932) about golang.org/x/crypto/openpgp, with a suggested maintained … Add the repository template sections: a What section that states the change (bump golang.org/x/crypto v0.57.0 to v0.59.0 and the related indirect updates), a Why section that explains the security need (GO-2026-5932, openpgp package), and a…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the main change: updating golang.org/x/crypto from v0.57.0 to v0.59.0 in the Go modules. The changeset updates that dependency in go.mod, acceptance/go.mod, and tools/go.mod, so the ti…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: updating golang.org/x/crypto from v0.57.0 to v0.59.0 in the Go modules. The changeset updates that dependency in go.mod, acceptance/go.mod, and tools/go.mod, so the title matches the primary change. It also flags the security nature of the update, which the PR metadata supports.

Full details: Description check

Explanation

The description follows the Renovate-generated format. It gives the package, version change, and a vulnerability advisory (GO-2026-5932) about golang.org/x/crypto/openpgp, with a suggested maintained alternative. It does not fill the repository template's What, Why, or Tickets sections. The Why context is covered by the advisory, but the What section is only implied by the update table, and no Jira ticket is linked.

Resolution

Add the repository template sections: a What section that states the change (bump golang.org/x/crypto v0.57.0 to v0.59.0 and the related indirect updates), a Why section that explains the security need (GO-2026-5932, openpgp package), and a Tickets section that links the related Jira issue, or states that none exists.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 6b7268e4-e291-40ee-81ae-5a4f8d1335e0
Commits

Reviewing files that changed from the base of the PR and between 3bc55d6 and b7ea577.

Files ignored due to path filters: 3

  • acceptance/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • tools/go.sum is excluded by !**/*.sum
Files selected for processing: 3

  • acceptance/go.mod
  • go.mod
  • tools/go.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review.

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 12, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Bot-authored security dependency update bumping golang.org/x/crypto across three Go modules; the change is purely go.mod/go.sum with no source code modifications, keeping implementation risk low, though the security label and 6 dependency files spanning multiple modules slightly elevate the score above minimal.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: Dependency file update in Go modules warrants dependencies and go labels.

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W119 -->

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 12, 2026
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.61% <ø> (ø)
generative 12.22% <ø> (ø)
integration 23.62% <ø> (ø)
unit 72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code ready-for-merge All reviewers approved — ready to merge renovate risk/moderate PR risk: moderate security size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants