Skip to content

Enable xeus-cpp to be built as an llvm external project for Emscripten build, and enable xeus-cpp to use Emscripten static library build of CppInterOp - #499

Open
mcbarton wants to merge 1 commit into
compiler-research:mainfrom
mcbarton:static-cppinterop-build
Open

mcbarton wants to merge 1 commit into
compiler-research:mainfrom
mcbarton:static-cppinterop-build

Conversation

@mcbarton

@mcbarton mcbarton commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

This PR enables xeus-cpp to be built as an llvm external project for the Emscripten build, and enable xeus-cpp to use Emscripten static library build of CppInterOp.

The build which doesn't build xeus-cpp as part of llvm currently requires compiler-research/CppInterOp#1149 which is this PR targets the cppinterop-v2.0 branch

This PR is such that the xeus-cpp will build with whatever CppInterOp library happens to be available. It doesn't care if CppInterOp is a shared or static library. The tests pass regardless.

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton

mcbarton commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

xeus-cpps cppinterop-v2.0 branch needs rebasing on the main branch, in order to remove most of the commits currently showing in this PR (and to show the exact diff relevant to this PR goal).

@mcbarton

Copy link
Copy Markdown
Collaborator Author

Just in case it isn't obvious, the deployment ci will not pass for this PR, since it is pointing to a branch targetting CppInterOp v2.0, with CppInterOp v1.9.0

@mcbarton
mcbarton force-pushed the static-cppinterop-build branch from e63c1bb to 91c8e75 Compare October 30, 2026 15:25
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
mcbarton force-pushed the static-cppinterop-build branch from 19b5f1a to e334ea6 Compare October 30, 2026 15:39
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
mcbarton changed the base branch from cppinterop-v2.0 to main November 9, 2026 19:36
@mcbarton
mcbarton force-pushed the static-cppinterop-build branch from e334ea6 to 964229c Compare November 9, 2026 19:37
@codecov-commenter

codecov-commenter commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.70%. Comparing base (2be8b64) to head (3c8645f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   72.70%   72.70%           
=======================================
  Files          18       18           
  Lines        1209     1209           
  Branches      115      115           
=======================================
  Hits          879      879           
  Misses        330      330           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton

mcbarton commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator Author

@vgvassilev @Vipul-Cariappa can you review this PR for me? The ci is red as it needs my CppInterOp v2.0 update PR to go in first, and be rebased for the ci to go green.

@anutosh491

anutosh491 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

To be fair I'm not convinced (fully) here. There's many way's a kernel can be configured. And we as kernel maintainer should probably provide the best one any for anybody making use of it. So if we can claim that the static build is absolutely the better one then let's just promote that right ?

Giving multiple ways to build is just looking like unecessary maintaince isn' it ?

@mcbarton
mcbarton force-pushed the static-cppinterop-build branch from 964229c to 709a7c6 Compare November 13, 2026 17:33
@mcbarton
mcbarton force-pushed the static-cppinterop-build branch from 709a7c6 to 3c8645f Compare November 15, 2026 08:35

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants