Repository navigation
Enable xeus-cpp to be built as an llvm external project for Emscripten build, and enable xeus-cpp to use Emscripten static library build of CppInterOp - #499
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
xeus-cpps cppinterop-v2.0 branch needs rebasing on the main branch, in order to remove most of the commits currently showing in this PR (and to show the exact diff relevant to this PR goal). |
|
Just in case it isn't obvious, the deployment ci will not pass for this PR, since it is pointing to a branch targetting CppInterOp v2.0, with CppInterOp v1.9.0 |
e63c1bb to
91c8e75
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
19b5f1a to
e334ea6
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
e334ea6 to
964229c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 72.70% 72.70%
=======================================
Files 18 18
Lines 1209 1209
Branches 115 115
=======================================
Hits 879 879
Misses 330 330 🚀 New features to boost your workflow:
|
|
@vgvassilev @Vipul-Cariappa can you review this PR for me? The ci is red as it needs my CppInterOp v2.0 update PR to go in first, and be rebased for the ci to go green. |
|
To be fair I'm not convinced (fully) here. There's many way's a kernel can be configured. And we as kernel maintainer should probably provide the best one any for anybody making use of it. So if we can claim that the static build is absolutely the better one then let's just promote that right ? Giving multiple ways to build is just looking like unecessary maintaince isn' it ? |
964229c to
709a7c6
Compare
…InterOp, and as an external llvm project
709a7c6 to
3c8645f
Compare
This PR enables xeus-cpp to be built as an llvm external project for the Emscripten build, and enable xeus-cpp to use Emscripten static library build of CppInterOp.
The build which doesn't build xeus-cpp as part of llvm currently requires compiler-research/CppInterOp#1149 which is this PR targets the cppinterop-v2.0 branch
This PR is such that the xeus-cpp will build with whatever CppInterOp library happens to be available. It doesn't care if CppInterOp is a shared or static library. The tests pass regardless.