Repository navigation
Conversation
This was referenced Nov 13, 2026
kim
force-pushed
the
kim/local-tier-reclamation
branch
from
November 13, 2026 17:28
9a7fd8e to
89c0e6c
Compare
Tracks backing storage ownership in the page manager and blob set. After transactions and under memory budget pressure, orphaned objects are reclaimed.
kim
force-pushed
the
kim/local-tier-reclamation
branch
from
November 13, 2026 17:31
89c0e6c to
0cff851
Compare
joshua-spacetime
requested changes
Nov 13, 2026
|
|
||
| let mut freed = 0; | ||
| for (key, slot) in slots { | ||
| let mut entry = slot.state.lock(); |
Collaborator
There was a problem hiding this comment.
Could we use try_lock() here instead of lock(), and set should_reclaim if the slot is in use? Note that write() can acquire locks in the opposite order: First object and then catalog.
Collaborator
There was a problem hiding this comment.
I'm not sure this lock will ever be in use during reclaim, so this might not actually be a problem. But I don't think it hurts regardless.
Comment on lines
+633
to
+634
| let mut slots = catalog | ||
| .iter() |
Collaborator
There was a problem hiding this comment.
Not a blocker, but I think we should at least add a TODO that reclaim not iterate the entire catalog.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks backing storage ownership in the page manager and blob set. After transactions and under memory budget pressure, orphaned objects are reclaimed.
API and ABI breaking changes
N/A
Rollback safety impact
N/A
Expected complexity level and risk
3 - Makes the locking protocol in
TieredStoragemore complicatedTesting
Yes