Skip to content

Allow patched dependency versions on the pinned Citus main runtime - #6

Open
ibrahim halatci (ihalatci) wants to merge 2 commits into
mainfrom
ihalatci-dependency-bounds-main
Open

ibrahim halatci (ihalatci) wants to merge 2 commits into
mainfrom
ihalatci-dependency-bounds-main

Conversation

@ihalatci

@ihalatci ibrahim halatci (ihalatci) commented Nov 13, 2026 •

Copy link
Copy Markdown

Description

Allow the exact patched dependency versions required by the Citus main line, preserving every lower bound, Python >=3.12, unrelated dependencies, and runtime source:

Dependency Existing upper bound New upper bound
Brotli 1.2.0 1.2.1
msgpack 1.2.1 1.2.3
tornado 6.5.8 6.6
urwid 4.0.0 4.0.7

#5 merged into main as ea6c4c3f782ffa61494aeddccd8116f0ca2b4c15. This PR targets main; its diff contains the four pyproject.toml cap changes and the corresponding four root requirement specifiers in uv.lock. All resolved package versions, artifact hashes, Python requirements, and runtime source are unchanged. No merge or stable-image promotion is authorized by this update.

Commit provenance:

  • 0dac7e3f656baf0ac5b9bfcb1c13aa01cad2faa5 contains the cap changes, based directly on the existing Citus runtime pin a16444362cc0393ccf7329f50fc909b711729de7.
  • Current head 2f2b5de5baceb161326503dd1602940530032868 appends only the lock metadata correction. It does not rewrite the published runtime pin; downstream refs remain unchanged.

Actual fork CI status (2026-11-16):

  • Original CI and autofix failed because this PR introduced stale root requirements in uv.lock. Locked tox jobs aborted before checks/tests: "The lockfile ... needs to be updated, but --locked was provided". Autofix generated the same four-line lock correction. The main baseline CI passed. This introduced defect is corrected by the follow-up commit.
  • New autofix passed.
  • New PR merge CI has no failures so far: all test, offline, lint, filename, mypy, individual coverage, old-dependencies, web, docs, wheel and Windows/macOS build jobs have finished successfully. The two Debian 12 Linux build jobs are still running; overall success is not yet claimed.
  • The separate feature-branch push CI remains red: both Debian 11 Linux build jobs fail downloading Bullseye packages with HTTP 404 before Python execution. This historical pinned branch retains the old Debian 11 workflow; the Debian 12 workflow change is already in merged Unblock security dependency updates and retire Bullseye #5/main and is used by PR merge CI. No workflow-history merge, package-repository bypass, or test weakening was performed. Therefore the PR check rollup is still not all green.

Validation from /home/ihalatci/Development/mitmproxy-dependency-bounds on WSL Linux:

  • uv pip install --python env-main/bin/python -e ./main --group main/pyproject.toml:dev Brotli==1.2.1 msgpack==1.2.3 tornado==6.6 urwid==4.0.7 - passed on Python 3.12.12, full resolution without dependency bypass.
  • uv pip check --python env-main/bin/python - passed.
  • env-main/bin/mitmdump --version - passed, OpenSSL 4.0.1.
  • From the main checkout: VIRTUAL_ENV=/home/ihalatci/Development/mitmproxy-dependency-bounds/env-main uv run --active --no-project --python ../env-main/bin/python pytest -q --timeout 60 test/mitmproxy/net/test_encoding.py test/mitmproxy/tools/console test/mitmproxy/tools/web test/mitmproxy/io test/mitmproxy/contentviews test/mitmproxy/addons/test_onboarding.py - 298 passed, 1 skipped against exact updated targets. The skip is not used as compatibility evidence.
  • uv lock --check --python /home/ihalatci/.local/bin/python3.12 - reproduced the stale-lock failure before correction; passed afterward.
  • UV_PROJECT_ENVIRONMENT=/home/ihalatci/Development/mitmproxy-dependency-bounds/env-ci-lock uv sync --locked --python /home/ihalatci/.local/bin/python3.12 --only-group tox - passed.
  • UV_PROJECT_ENVIRONMENT=/home/ihalatci/Development/mitmproxy-dependency-bounds/env-ci-lock uv run --locked --python /home/ihalatci/.local/bin/python3.12 --only-group tox tox -e lint,filename_matching,mypy,individual_coverage - lint, filename matching, and mypy passed. Individual coverage on Python 3.12 missed only the unchanged Python >=3.13 imports in certs.py:33 and contentviews/_compat.py:16; CI-matching interpreter rerun passed below.
  • UV_PROJECT_ENVIRONMENT=/home/ihalatci/Development/mitmproxy-dependency-bounds/env-ci314 uv run --locked --python /home/ihalatci/.local/share/uv/python/cpython-3.14.2-linux-x86_64-gnu/bin/python3.14 --only-group tox tox --workdir /home/ihalatci/Development/mitmproxy-dependency-bounds/tox-ci314 -e individual_coverage - passed, full individual coverage gate on Python 3.14.2.
  • UV_PROJECT_ENVIRONMENT=/home/ihalatci/Development/mitmproxy-dependency-bounds/env-ci-lock uv run --locked --python /home/ihalatci/.local/bin/python3.12 --only-group tox tox -e py312 -- test/mitmproxy/net/test_encoding.py test/mitmproxy/tools/console test/mitmproxy/tools/web test/mitmproxy/io test/mitmproxy/contentviews test/mitmproxy/addons/test_onboarding.py - corrected-lock run passed: 298 passed, 1 skipped.

Downstream integration is separately verified at the original runtime-equivalent 0dac7e3f pin: Citus source 223abeeb16eea4e881da5e9ba9877caee4f0ec51 passed full pipenv sync --dev, dependency consistency, and startup on Python 3.12.12. Its development image is image-dev-74bd9f9 from the-process 74bd9f9e4b446f9291459f49fc353633bbc805cc. Citus full CI passed on 99fab5d1803c0186ce127f200ac8489de0bc7aa8, including all 12 check-failure, check-enterprise-failure, check-pytest, and check-query-generator jobs across PG17/18/19, without skipped failure gates. Consumer: citusdata/citus#8973. Downstream success does not imply fork CI is green.

The full fork tox suite and offline-network suite were not run locally; remote CI is authoritative for those gates. Existing tests cover the affected APIs; no new tests or changelog entry were added for this metadata-only prerequisite. Historical release-14 and legacy refs are separate and are not included here.

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@autofix-troubleshooter

Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

Keep resolved dependency versions unchanged while matching the four widened project requirements.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants