Repository navigation
Conversation
larsewi
requested changes
Nov 20, 2026
victormlg
force-pushed
the
strtotime-arg-injection
branch
from
November 20, 2026 11:31
f67c8fa to
da3c763
Compare
The pipe to date was closed with `fclose()`, which does not wait for the child. Changelog: Title Signed-off-by: Victor Moene <victor.moene@northern.tech>
…_than()` The date was embedded in a command string, so quotes in it could add arguments to date. It is now passed to date as a separate argument. Changelog: Title Ticket: ENT-14983 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
strtotime-arg-injection
branch
from
November 20, 2026 12:27
da3c763 to
191fa38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To also cover Windows, I made arglist elements get quoted before they are passed to CreateProcess(), in https://github.com/cfengine/enterprise/pull/1039