Repository navigation
ENT-14276: Refactor Addr lib #6485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
victormlg
wants to merge
22
commits into
cfengine:master
Choose a base branch
from
victormlg:addr_lib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2367056
Added unit tests for FuzzySetMatch() and ParseHostPort()
victormlg 93ecf30
Extracted MatchPrefix() from FuzzySetMatch()
victormlg 47d645e
Extracted MatchIPv4CIDR() from FuzzySetMatch()
victormlg 9bb2f43
Extracted MatchIPv4Range() from FuzzySetMatch()
victormlg 32085e2
Extracted MatchIPv6CIDR() from FuzzySetMatch()
victormlg faefd14
Extracted MatchIPv6Range() from FuzzySetMatch()
victormlg a35d555
Extracted GetPatternNotation() from FuzzySetMatch()
victormlg c6e2947
Restructured ParseHostPort()
victormlg 078426a
Removed declaration of IsLoopbackAddress()
victormlg ec2ff05
Fixed IPv6 range patterns comparing groups as decimal numbers
victormlg 473ba52
Fixed IPv6 range patterns excluding the lower bound of a range
victormlg a55c1cc
IPv6 range patterns now support `::`
victormlg bc97da1
Fixed bug where IPv4 range patterns reused values from the previous o…
victormlg f02295c
IPv4 CIDR patterns with an invalid network address, e.g. `bogus/0`, a…
victormlg a9c77d4
Policy functions `iprange()` and `isipinsubnet()` now detect invalid …
victormlg 2af3afa
Fixed out-of-bounds read in `hostrange()` on all-digit host names
victormlg 97a0e4e
Fixed sys.policy_hub when bootstrapped to a host name starting with a…
victormlg acda8ce
Renamed address matching functions after their policy functions
victormlg e3d1a36
Added assert to access_CheckResource()
victormlg bc62b2d
Replaced strchr() with StringContainsChar() in addr_lib.c
victormlg 2003c09
Replaced strstr() and strcmp() with String*() helpers in addr_lib.c
victormlg 2e725a0
`iprange()` and `isipinsubnet()` now log invalid arguments at verbose…
victormlg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.