Skip to content

Treat an unspecified extension version as version 0 in cel::Config and the env YAML parser, consistent with cel-go and cel-java. #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Treat an unspecified extension version as version 0 in cel::Config and the env YAML parser, consistent with cel-go and cel-java. #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cel_expr_python/cel_env_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,6 @@ def test_config_export_extension_version(self):
extensions:
- name: "bindings"
- name: "math"
version: 0
- name: "optional"
version: 1
- name: "strings"
Expand Down Expand Up @@ -469,7 +468,9 @@ def test_config_extensions(self):
config: cel.EnvConfig = cel.NewEnvConfigFromYaml("""
extensions:
- name: math
version: latest
- name: strings
version: latest
""")
env: cel.Env = cel.NewEnv(
config=config,
Expand All @@ -481,7 +482,9 @@ def test_config_extensions(self):
normalize_yaml("""
extensions:
- name: "math"
version: latest
- name: "strings"
version: latest
- name: "test_cel_extension"
"""),
)
Expand All @@ -494,6 +497,7 @@ def test_standard_extensions_via_config(self):
config: cel.EnvConfig = cel.NewEnvConfigFromYaml("""
extensions:
- name: lists
version: latest
- name: sets
- name: two-var-comprehensions
- name: optional
Expand Down
4 changes: 1 addition & 3 deletions cel_expr_python/py_cel_env_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,7 @@ PyCelEnvInternal::NewCelEnvInternal(
name = extension->name();
}
CEL_PYTHON_RETURN_IF_ERROR(config.AddExtensionConfig(
name, extension->version() >= 0
? extension->version()
: cel::Config::ExtensionConfig::kLatest));
name, extension->version() >= 0 ? extension->version() : 0));
extension_handles.push_back(std::move(handle));
}

Expand Down
Loading