Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugzilla 5.0 and 5.2 moved aliases into a bugs_aliases table and dropped bugs.alias. Harmony re-creates bugs.alias empty during checksetup (Bugzilla/Install/DB.pm:287), so a 5.x upgrade currently loses every alias.
This is the migration-only approach agreed with Dave on Oct 15:
Tested against a simulated 5.x schema: aliases migrated, bugs_aliases unchanged, rerun is a no-op, a cleared alias stays cleared, REST lookup by alias works. Databases without bugs_aliases (4.4 path) are unaffected. prove t/ passes apart from the existing bounced-emails.t failure; the bmo option passes.
This covers the "Multiple aliases was reverted" item under "Upgrade Path" in RELEASE_BLOCKERS.md and is one of the dependencies of 1896011.