Repository navigation
Conversation
Port /parameters from upstream Bugzilla (bug 443210). Logged-out users get maintainer and requirelogin, logged-in users get the params already visible in the web UI, and tweakparams members get every param. In Harmony, urlbase and attachment_base moved from data/params to localconfig, so they are served from Bugzilla->localconfig. cookiepath and maxlocalattachment no longer exist and are omitted. last_audit_time from the same upstream patch is not included.
mrenvoize
left a comment
There was a problem hiding this comment.
Requesting changes, mostly for tests and a policy decision. The access model reads as sound (anonymous gets maintainer/requirelogin; logged-in users a whitelist; tweakparams all keys).
- Secrets via the API: please decide whether
tweakparamsusers should receive secret params (smtp_password,aws_secret_access_key,duo_skey,duo_akey,duo_ikey). The web UI already shows them, but the API is easier to scrape; I'd suggest masking them. - Tests: there are none, and the webservice tests do not run in CI (the job is commented out in
.github/workflows/ci.yml:28-37). Please add tests for the anonymous, logged-in and admin views and run them locally. - The docs say "Restored in 6.0" but
BUGZILLA_VERSIONis 5.9.1+; please correct. perltidy flags line 185.
|
Thanks. On secrets, I'll mask them: smtp_password, aws_secret_access_key, duo_skey, duo_akey and duo_ikey will come back masked even for tweakparams users. I'll also add webservice tests for the anonymous, logged-in and admin views, run them locally since the CI job is still disabled, and fix the version wording and line 185. |
Thanks for the review. Addressed in deb53be:
|
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1582393
The /parameters endpoint returned "No such method" because Bugzilla.parameters was never ported to Harmony. This ports it from upstream Bugzilla (bug 443210), keeping the same access tiers:
Harmony-specific changes:
Not included: last_audit_time from the same upstream patch. It is a separate method outside this bug, and I can port it separately if wanted.
Tested locally in Docker:
The plain logged-in tier was not exercised live because my local DB has no non-admin test user. It runs the same code path with a different parameter list.