Skip to content

[harmony] Bug 2069203: Fix potential loading issues when loading Oracle database driver - #185

Merged
justdave merged 3 commits into
mainfrom
bug-2069203-harmony
Nov 9, 2026
Merged

justdave merged 3 commits into
mainfrom
bug-2069203-harmony

Conversation

@justdave

@justdave justdave commented Sep 4, 2026

Copy link
Copy Markdown
Member

Details

Changing the loading of the parent class to work the same way it does on the other branches, which is proven stable and reduces the potential for mis-loading a generated Perl module.

Additional info

@justdave
justdave requested a review from LpSolit September 4, 2026 04:27
@mrenvoize

Copy link
Copy Markdown
Contributor

Looks good: I confirmed use base qw(DBI::st) fails when DBI isn't loaded yet and the parent form with -norequire works, and it matches origin/5.2. Before merging, please check the upstream history: the same fix landed on origin/5.2 as f5f76574f, and a revert (3bf9b3027) exists on the revert-251-bug-2069203-5.2 branch. I want to be sure that revert wasn't intentional before this goes onto main.

@justdave

justdave commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Before merging, please check the upstream history: the same fix landed on origin/5.2 as f5f76574f, and a revert (3bf9b3027) exists on the revert-251-bug-2069203-5.2 branch. I want to be sure that revert wasn't intentional before this goes onto main.

That had to be accidental. There is a mention of me flubbing the commit message, and that may have been an aborted attempt to fix the commit message.

@mrenvoize mrenvoize left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Confirmed that use base qw(DBI::st) fails when DBI isn't loaded yet and the -norequire parent form works. The upstream revert (3bf9b3027) was accidental per the author, so this is safe to land.

@justdave
justdave merged commit 3da95cc into main Nov 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants