Repository navigation
docs(jafar-perf): describe the fixed jfr_use/jfr_tsa time window and time-filter cost - #21
Merged
Merged
Conversation
…time-filter cost btraceio/jafar#206 made the startTime/endTime window of jfr_use and jfr_tsa work and stated its contract: nanoseconds from the recording's start, with an epoch-nanosecond timestamp also accepted. The latency skill showed the window with a bare <ns> and said nothing about jfr_tsa or how to confirm the result, so it now gives the contract and points at the three new timeWindow fields (recordingStartEpochNanos, startTimeEpochNanos, endTimeEpochNanos). The same change made JfrPath decode only the event types a query names and skip chunks that ended before a lower bound on startTime. The jfrpath skill named the time predicates without a signature; it now shows them and says which filters make a query cheaper on a large recording. The plugin still pins jfr-mcp 0.29.0, which predates the fix, so the latency skill also says how to recognise a result from such a server. Verified: check-tool-references.js passes against the pinned release, the latest release and a jar built from jafar main (37 tools each); validate-marketplace.sh passes; a stdio probe of the main build on test-ap.jfr returned the same 4296 samples for offset and epoch bounds, matching the jfr_query count for that window. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
btraceio/jafar#206 made the
startTime/endTimewindow ofjfr_useandjfr_tsawork and stated its contract. It also made JfrPath queries cheaper in two cases. This brings thejafar-perfskills in line.latencyskilljfr_use startTime=<ns> endTime=<ns> resources=threads. It did not say what<ns>is measured from, thatjfr_tsatakes the same bounds, or how to read the result.recordingStartEpochNanos,startTimeEpochNanosandendTimeEpochNanosin the result'stimeWindow. It also shows how to run ajfr_queryover the same window.jfrpathskillbefore,afterandonwere named with no signature or example.startTimein the root brackets.No skill or agent text depended on the old broken window, so nothing was removed. No tool or parameter was renamed, so allowlists are unchanged.
How verified
node scripts/check-tool-references.js --pinnednode scripts/check-tool-references.jsmainnode scripts/check-tool-references.js --jar <shadow jar built from 724d2d28>scripts/validate-marketplace.shmainbuildtest-ap.jfr, window 20 s–40 sjfr_tsareturns 4296 samples for offset bounds and for epoch bounds, equal to thejfr_querycount for that window;timeWindowcarries the three new fieldstimeWindowhas no new fieldsCoverage notes
The tool-reference check catches renamed or removed tools, not changed parameters. The parameter contract was checked by reading the schemas and
resolveTimeWindowon jafarmainand by the probe above.Not verified / known limitations
io.btrace:jfr-mcp:0.29.0, and no release contains 724d2d28 yet. Until the pin moves, offsets from the recording's start select nothing on installed servers. Thelatencyskill says how to recognise such a result (atimeWindowwithout the three new fields); that sentence can go once the pin moves.doc/cli/JFRPath.mdon jafarmain.CHANGELOG.mdis not updated.Breaking changes / migration
None.
Links
🤖 Generated with Claude Code