Repository navigation
LTS-5442: bump browserstack-node-sdk to 1.73.4, pin Semgrep digest - #25
Merged
Merged
Conversation
- LTS-5507 / LTS-5513: browserstack-node-sdk 1.61.0 -> 1.73.4. 1.73.4 is the newest release that clears min-release-age=7 and requires patched simple-git ^4.0.2 (with @simple-git/argv-parser 2.x) and @grpc/grpc-js ^1.14.5, so both advisory chains are fixed through the SDK's own ranges with no forced overrides. The WDIO runner pod does not use this SDK (it runs @wdio/browserstack-service); here it only provides the local browserstack-cli used to start the load test. - LTS-5519: pull returntocorp/semgrep:1.166.0 by digest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
MohitSinghBS
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three findings from the LTS-5442 security AI review of this sample.
Changes
simple-gitOS command injection (GHSA-v5rq-49vh-5v5c, -858h-whjf-mvg5, -g4wm-2vf7-vfgr, -x6jw-m9v5-85vh) came in viabrowserstack-node-sdk@1.61.0→simple-git ^3.28.0.@grpc/grpc-js@1.14.4TLS validation bypass (GHSA-m9gg-hp2v-232j) via the same SDK →grpc-js ^1.14.4.returntocorp/semgrep:1.166.0@sha256:c180f0c93a17b420c0af5006214a29d3c747c5459c732b740191adf657dd0068.The fix for both SDK stories:
browserstack-node-sdk1.61.0→1.73.4. That is the newest release that clears this repo'smin-release-age=7(published 2026-10-19), and it already requiressimple-git ^4.0.2and@grpc/grpc-js ^1.14.5. The SDK's own ranges fix both chains, so no overrides force a major version under it. 1.74.0, the version the review suggested, is still inside the 7-day window.Runner impact: none. The WDIO runner pod doesn't use
browserstack-node-sdk; it runs@wdio/browserstack-service. In this sample the SDK only provides the localbrowserstack-clithat starts the load test.Verification
npm ci --ignore-scriptsresolvessimple-git@4.0.2,@simple-git/argv-parser@2.0.1and@grpc/grpc-js@1.14.6, each as the only copy in the lock.npx --no-install browserstack-cli --version→ 1.73.4.wdio --version→ 9.29.1, andwdio.conf.jsloads.npm audit, before → after: 33 → 25 issues, Critical 2 → 0, High 22 → 21. Cleared:simple-git,@simple-git/argv-parser,@grpc/grpc-js,googleapis,googleapis-common,gaxios,qs,uuid. Nothing new appears.Not in scope
The 21 remaining Highs are already on
main, in the WDIO / Percy / proxy-agent tree. The review did not raise them.The load-testing-backend copy of this sample (
sample/sample-webdriverio-repo.zip) is updated in load-testing-backend#3604.Part of LTS-5442.
🤖 Generated with Claude Code