Skip to content

cmake: require CMake 3.13; build the tests without a PCH below 3.16 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jll63 merged 1 commit into from
Nov 12, 2026
Merged

cmake: require CMake 3.13; build the tests without a PCH below 3.16 #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#
#-------------------------------------------------

cmake_minimum_required(VERSION 3.16...3.20)
cmake_minimum_required(VERSION 3.13...3.20)

set(BOOST_OPENMETHOD_VERSION 1)

Expand Down
6 changes: 5 additions & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ endfunction()
# precede the #define and defeat the override, so those files are left without a
# PCH.
#
# target_precompile_headers needs CMake 3.16, and the library supports 3.13, so
# the tests simply build without a PCH on anything older - slower, not different.
#
# Detected by scanning for the macro, or for an include of a header that carries
# the override on the file's behalf: test_capture_errors.hpp and
# test_checked_registry.hpp each own a whole recipe, so the tests including them
Expand Down Expand Up @@ -154,7 +157,8 @@ foreach(test_cpp ${test_cpp_files})
# is compiled without the flag, and GCC then warns (-Winvalid-pch) that it
# was "created and used with differing settings of '-mbmi2'" for every file
# that reuses it with the flag on.
if (test_cpp_overrides_registry EQUAL -1 AND NOT test_needs_bmi2)
if (test_cpp_overrides_registry EQUAL -1 AND NOT test_needs_bmi2
AND NOT CMAKE_VERSION VERSION_LESS 3.16)
if (NOT boost_openmethod_pch_owner)
target_precompile_headers(${test_target} PRIVATE ${BOOST_OPENMETHOD_TEST_PCH_HEADERS})
set(boost_openmethod_pch_owner ${test_target})
Expand Down
2 changes: 1 addition & 1 deletion test/cmake_test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# https://www.boost.org/LICENSE_1_0.txt
#

cmake_minimum_required(VERSION 3.16...3.20)
cmake_minimum_required(VERSION 3.13...3.20)

project(cmake_test LANGUAGES CXX)
set(__ignore__ ${CMAKE_C_COMPILER})
Expand Down
Loading