Skip to content

chore: ask for just pre-push in PR template - #386

Open
vadim-anfv wants to merge 1 commit into
bitcoindevkit:masterfrom
vadim-anfv:chore/pr-template
Open

vadim-anfv wants to merge 1 commit into
bitcoindevkit:masterfrom
vadim-anfv:chore/pr-template

Conversation

@vadim-anfv

@vadim-anfv vadim-anfv commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Description

cargo fmt and cargo clippy miss the feature-gated failures that CI then reports. just pre-push also runs the tests and clippy with -D warnings on both feature sets.

Notes to the reviewers

That cargo line in checks below comes from the current template, not the new one.
And yes, I did run the commands.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.51%. Comparing base (5558555) to head (dce8f4b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   60.00%   59.51%   -0.50%     
==========================================
  Files          25       25              
  Lines        4736     4552     -184     
==========================================
- Hits         2842     2709     -133     
+ Misses       1894     1843      -51     
Flag Coverage Δ
rust 59.51% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvpeter tvpeter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dce8f4b

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants