[emma31-dev]

Description

Propagate PSBT decoding and parsing errors instead of wrapping them in Error::Generic.

• BASE64_STANDARD.decode() failures in sign, finalize_psbt, and broadcast now propagate directly via ?
• Psbt::deserialize() failures are no longer swallowed into a generic string message
• BlockchainClient::broadcast() maps backend errors to dedicated typed variants (Error::Electrum, Error::Esplora, Error::BitcoinCoreRpcError)
• wallet.apply_update() / apply_update_events() map to Error::Chain instead of Error::Generic
• Integration tests added for sign, finalize_psbt, and broadcast error paths

Fixes #357 . Related to the broader error-propagation cleanup across the codebase.

Notes to the reviewers

Uses the existing From conversions for DecodeError and PsbtError.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

Bugfixes:

• I'm linking the issue being fixed by this PR

[tvpeter]

This a low impact PR. The only thing it did is change the error type from "Generic error" to "Basse64 decoding error". Maybe you should extend it to cover finalize_psbt and broadcast, because they also return the "Generic" error type. Also, you can add a test that they return the specific error.

Thank you

[emma31-dev]

@tvpeter I've extended it past just sign.

[muawiya1]

While reviewing this PR, I added five tests to help cover the specific errors mentioned in the review, the tests check that sign and finalize_psbt return the expected errors for invalid base64 and invalid psbt data, they also check the base64 decoding error for broadcast --psbt.

All the 13 tests in the offline test module passed successfully locally including the new five added tests.

This is my test commit: 1d00acd @emma31-dev, you can check and cherry-pick it if it’s useful.

@tvpeter, I also want to check if this covers what you have in mind, I’m happy to adjust if needed.

[emma31-dev]

@muawiya1 Thanks. send a pr to this branch or if its too stressful to you i'll copy it out

[tvpeter]

ACK d8176e8

Please update the PR description to capture the changes.

Thank you.

[emma31-dev]

@tvpeter I have updated the PR description. Thank you.

[tvpeter]

@tvpeter I have updated the PR description. Thank you.

Ensure all the CI jobs are passing

[vadim-anfv]

@tvpeter I have updated the PR description. Thank you.

Ensure all the CI jobs are passing

It seems something wrong with CI, my pr template edit also fails on CI - https://github.com/bitcoindevkit/bdk-cli/pull/386/checks