Repository navigation
Apply recv_timeout to HTTP/3 requests - #1033
Merged
Merged
Conversation
A sync HTTP/3 request waited for its response with no timeout: a
server that stopped sending, before the headers or in the middle of
the body, blocked the caller forever. Each such stream now has a
recv_timeout watchdog, restarted on every headers or data event, as
HTTP/2 has. When it fires the stream is reset and the request fails
with {error, timeout}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sync HTTP/3 request had no timeout on its response. The caller waits with
infinityand nothing inhackney_connbounded the stream, so a server that stopped sending, before the headers or mid-body, blocked the request forever. The body size is already capped bymax_body_size; only the time was unbounded.Sync HTTP/3 streams now get the same per-stream
recv_timeoutwatchdog as HTTP/2. It restarts on each headers or data event, so the deadline counts from the last byte received. When it fires the stream is reset with H3_REQUEST_CANCELLED and the request fails with{error, timeout}; the connection stays usable.