Skip to content

Limit the size and count of HTTP/1.1 response headers - #1032

Merged
benoitc merged 1 commit into
masterfrom
fix/h1-header-limits
Nov 15, 2026
Merged

benoitc merged 1 commit into
masterfrom
fix/h1-header-limits

Conversation

@benoitc

@benoitc benoitc commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Nothing bounded an HTTP/1.1 response header section. max_line_length only covered the status line, so a server could send a header line that never ends, or an endless run of headers, and the client buffered all of it. An incomplete line was also rescanned from its start on every read.

The parser now caps the header section, trailers included, at 1 MiB and 1000 fields, and fails the request with {error, headers_too_large} or {error, too_many_headers}. The new max_header_size and max_headers request options change the caps (infinity disables them), for sync, async and streamed requests. An incomplete line is only scanned for the bytes that arrived since the last read.

Behaviour change: responses over these defaults, which used to be accepted, now fail.

Nothing bounded the response header section: a server could send a
header line that never ends, or headers without end, and the client
kept buffering. The parser now caps the section at 1 MiB and 1000
fields, trailers included, and returns headers_too_large or
too_many_headers past them. The max_header_size and max_headers
request options change the caps. An incomplete header line is no
longer rescanned from its start on every read.
@benoitc
benoitc merged commit 0368c12 into master Nov 15, 2026
6 checks passed
@benoitc
benoitc deleted the fix/h1-header-limits branch November 15, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant