Repository navigation
Limit the size and count of HTTP/1.1 response headers - #1032
Merged
Merged
Conversation
Nothing bounded the response header section: a server could send a header line that never ends, or headers without end, and the client kept buffering. The parser now caps the section at 1 MiB and 1000 fields, trailers included, and returns headers_too_large or too_many_headers past them. The max_header_size and max_headers request options change the caps. An incomplete header line is no longer rescanned from its start on every read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing bounded an HTTP/1.1 response header section.
max_line_lengthonly covered the status line, so a server could send a header line that never ends, or an endless run of headers, and the client buffered all of it. An incomplete line was also rescanned from its start on every read.The parser now caps the header section, trailers included, at 1 MiB and 1000 fields, and fails the request with
{error, headers_too_large}or{error, too_many_headers}. The newmax_header_sizeandmax_headersrequest options change the caps (infinitydisables them), for sync, async and streamed requests. An incomplete line is only scanned for the bytes that arrived since the last read.Behaviour change: responses over these defaults, which used to be accepted, now fail.