Repository navigation
Bound the SOCKS5 handshake by the connect timeout - #1031
Merged
Merged
Conversation
The SOCKS5 replies were read with an infinite timeout, so a proxy that
accepted the connection and then stopped answering blocked the caller
forever. The handshake now runs under the connect timeout and returns
{error, timeout}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SOCKS5 handshake read the proxy's replies with an infinite timeout.
connect_timeoutonly covered the TCP connect, so a proxy that accepted the connection and then stopped answering blocked the caller forever.The whole handshake (greeting, auth, connect reply, bound address) now runs under one deadline taken from the connect timeout, like the TLS upgrade that follows it, and returns
{error, timeout}. A short read of the bound address now returns an error instead of crashing on a badmatch.hackney_socks5:connect/3keeps its infinite timeout.