Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A queued
nonesent from Erlang became PythonNone, which the native async receive fast path treated as an empty queue. It consumed the message and then waited for another. A readiness callback also dequeued a message before waking the receiving task, so cancelling the task between notification and resumption lost that delivery.With a channel reference passed to Python, the first receive below timed out:
{ok, Ch} = py_channel:new(), ok = py_channel:send(Ch, none).Native async receive now uses the existing tagged
_channel_waitresult instead of the ambiguoustry_receiveresult. The callback signals readiness only; the task retries the atomic dequeue-or-register operation after resuming. A cancelled task therefore leaves the data queued. Native waiting stays native after an empty notification. The wait helper drains queued data before reporting closure, as the previous fast path did.No public signature changes. Non-native asyncio's executor fallback and synchronous
try_receivesemantics are unchanged. Channels remain explicitly unsupported in isolated contexts.OTP 28.3, conventional Python 3.12.16:
native_none_payload_testfailed withTimeoutError;native_cancel_ready_testfailed withAssertionError; isolated rejection passed.All 55 tests passed.rebar3 dialyzer,rebar3 xref: exit 0.make lint-docs check-code-map:lint-docs: clean (35 file(s));check_code_map: clean.Unmodified upstream baseline: 127 tests passed across channel, byte-channel, event-loop, pool, thread-callback, reentrant and callback-encoding suites.