Repository navigation
bugfix(browser): stop overwriting the guid with the session id - #415
Merged
Merged
Conversation
melekr
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The browser SDK keeps the same
guidacross sessions, and Backtrace no longer counts each new session as a new user.Changes
BacktraceBrowserSessionProvider.ts: keep the session id and its last-active time under their own storage keys, start a new session when no session id is stored.persistentSessionProviderTests.spec.ts: move the tests to the new keys, cover a missing session id, check the guid key and the old last-active key stay untouched.guidSessionTests.spec.ts: new, cover a guid that differs from the session id and stays the same across sessions and after an upgrade.Note
Existing users keep their
guidand start one new session on upgrade. The oldbacktrace-last-activekey is no longer used.ref: BT-7911