Skip to content

fix: add jira config section with enabled flag and env auth - #1841

Merged
avoidwork merged 5 commits into
mainfrom
fix/jira-config
Nov 16, 2026
Merged

avoidwork merged 5 commits into
mainfrom
fix/jira-config

Conversation

@avoidwork

@avoidwork avoidwork commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Description

Adds a jira section to config.yaml so JIRA_* env vars map correctly (enabled, baseUrl, email, token, project, assignee). JIRA_ENABLED=false skips tool registration; JIRA_EMAIL/JIRA_TOKEN provide default Basic auth, and JIRA_PROJECT/JIRA_ASSIGNEE default create (and project-scoped search). Fixes create to send fields.project as { key } per the Jira API. Removes the jira allowlist and the model-supplied baseUrl tool input, so jira.baseUrl is the only request target. Touches config.yaml, src/config/schemas/jira.js, src/tools/index.js, src/tools/jira/index.js, the jira unit/integration tests and coverage.txt.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes)
  • Performance improvement
  • CI / build / tooling

Testing

Updated the jira unit and integration tests for the { key } project shape and removed allowlist from their policies; all 26 jira tests pass. Verified env mapping by loading config with JIRA_* set. npm run lint and the full npm run coverage run pass. No new tests for config-default auth or enabled gating.

Coverage

  • Line coverage maintained

Checklist

  • npm run lint passes
  • Tests pass with maintained line coverage
  • No forbidden patterns used
  • Conventional Commit style applied

Threat model: the config token is never exposed to the model. With the allowlist removed, requests go only to the configured jira.baseUrl; the model can no longer supply a host.

Add jira block to config.yaml so JIRA_* env vars map (enabled, baseUrl,
email, token, project, assignee). Skip tool registration when disabled.
Send create project as { key } per the Jira API.
@avoidwork avoidwork added the bug Something isn't working label Nov 16, 2026
@avoidwork avoidwork self-assigned this Nov 16, 2026
The jira tool only targets the configured jira.baseUrl, so the
allowlist and the model-supplied baseUrl override are unnecessary.
@avoidwork avoidwork changed the title fix: add jira config section with enabled flag, env auth and defaults fix: add jira config section with enabled flag and env auth Nov 16, 2026
The jira tool targets a single site and authenticates from jira.email and
jira.token (JIRA_EMAIL / JIRA_TOKEN). Drop the credential tool input,
credentials config map, JiraCredentialSchema and resolveJiraCredential.
Jira PATs are sent as `Authorization: Bearer <token>` (JIRA_TOKEN), not
Basic email:token. Update the tool description to match.
Replace named credential profiles and the host allowlist with config-driven
JIRA_* settings, bearer personal access token auth, and the fixed baseUrl.
@avoidwork
avoidwork merged commit 81931b6 into main Nov 16, 2026
2 checks passed
@avoidwork
avoidwork deleted the fix/jira-config branch November 16, 2026 14:20
@avoidwork avoidwork mentioned this pull request Nov 16, 2026
6 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant