Repository navigation
fix: add jira config section with enabled flag and env auth - #1841
Merged
Merged
Conversation
Add jira block to config.yaml so JIRA_* env vars map (enabled, baseUrl,
email, token, project, assignee). Skip tool registration when disabled.
Send create project as { key } per the Jira API.
The jira tool only targets the configured jira.baseUrl, so the allowlist and the model-supplied baseUrl override are unnecessary.
The jira tool targets a single site and authenticates from jira.email and jira.token (JIRA_EMAIL / JIRA_TOKEN). Drop the credential tool input, credentials config map, JiraCredentialSchema and resolveJiraCredential.
Jira PATs are sent as `Authorization: Bearer <token>` (JIRA_TOKEN), not Basic email:token. Update the tool description to match.
Replace named credential profiles and the host allowlist with config-driven JIRA_* settings, bearer personal access token auth, and the fixed baseUrl.
6 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
jirasection toconfig.yamlsoJIRA_*env vars map correctly (enabled,baseUrl,email,token,project,assignee).JIRA_ENABLED=falseskips tool registration;JIRA_EMAIL/JIRA_TOKENprovide default Basic auth, andJIRA_PROJECT/JIRA_ASSIGNEEdefaultcreate(and project-scopedsearch). Fixescreateto sendfields.projectas{ key }per the Jira API. Removes the jiraallowlistand the model-suppliedbaseUrltool input, sojira.baseUrlis the only request target. Touchesconfig.yaml,src/config/schemas/jira.js,src/tools/index.js,src/tools/jira/index.js, the jira unit/integration tests andcoverage.txt.Type of Change
Testing
Updated the jira unit and integration tests for the
{ key }project shape and removedallowlistfrom their policies; all 26 jira tests pass. Verified env mapping by loading config withJIRA_*set.npm run lintand the fullnpm run coveragerun pass. No new tests for config-default auth orenabledgating.Coverage
Checklist
npm run lintpassesThreat model: the config
tokenis never exposed to the model. With the allowlist removed, requests go only to the configuredjira.baseUrl; the model can no longer supply a host.