Skip to content

fix(deploy-vercel): take the deployment URL by pattern, not the last stdout line - #28

Merged
jjavieralv merged 1 commit into
mainfrom
fix/deploy-url-from-stdout
Nov 16, 2026
Merged

jjavieralv merged 1 commit into
mainfrom
fix/deploy-url-from-stdout

Conversation

@tyhonchik

Copy link
Copy Markdown
Contributor

deploy-vercel.yml took the deployment URL as the last line of vercel deploy stdout. With pnpm 12's two-document lockfile, @vercel/build-utils (Vercel CLI 58.4.4, held for provenance) cannot parse pnpm-lock.yaml with js-yaml.safeLoad and logs Error while parsing config file to stdout, glued to the URL without a newline. On aragon/app#1582 the output became https://app-next-….vercel.appError while parsing config file: ".../pnpm-lock.yaml"; the deploy itself succeeded, but the PR comment links broke and e2e ran against that string until the job was cancelled. A production deploy would have tried to alias the same string.

Changes

  • The step keeps the full vercel deploy stdout (a failing deploy still fails the step) and takes the last https://<name>.vercel.app match from it. No match still stops the step with the existing "printed no deployment URL" error.

Needs v1.0.2 after merge; aragon/app#1582 then reruns its preview.

🤖 Generated with Claude Code

…stdout line

With pnpm 12's two-document lockfile, @vercel/build-utils logs
"Error while parsing config file" to stdout right after the URL, so
the last line came out as <url>Error while parsing ... and e2e ran
against it.

@jjavieralv jjavieralv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjavieralv
jjavieralv merged commit 6e61399 into main Nov 16, 2026
4 checks passed
@jjavieralv
jjavieralv deleted the fix/deploy-url-from-stdout branch November 16, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants