Repository navigation
fix(deploy-vercel): take the deployment URL by pattern, not the last stdout line - #28
Merged
Merged
Conversation
…stdout line With pnpm 12's two-document lockfile, @vercel/build-utils logs "Error while parsing config file" to stdout right after the URL, so the last line came out as <url>Error while parsing ... and e2e ran against it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-vercel.ymltook the deployment URL as the last line ofvercel deploystdout. With pnpm 12's two-document lockfile,@vercel/build-utils(Vercel CLI 58.4.4, held for provenance) cannot parsepnpm-lock.yamlwithjs-yaml.safeLoadand logsError while parsing config fileto stdout, glued to the URL without a newline. On aragon/app#1582 the output becamehttps://app-next-….vercel.appError while parsing config file: ".../pnpm-lock.yaml"; the deploy itself succeeded, but the PR comment links broke and e2e ran against that string until the job was cancelled. A production deploy would have tried to alias the same string.Changes
vercel deploystdout (a failing deploy still fails the step) and takes the lasthttps://<name>.vercel.appmatch from it. No match still stops the step with the existing "printed no deployment URL" error.Needs
v1.0.2after merge; aragon/app#1582 then reruns its preview.🤖 Generated with Claude Code