Repository navigation
feat: reference the modules through the moving major tag - #26
Merged
Merged
Conversation
The reusable workflows and the examples reference the composite actions and each other @v1, the tag the consumers point at, so a v1 consumer never runs v2 code; release-self refuses to move a major tag backwards and a test keeps every self-reference on one major. Docs describe the @v1 model instead of SHA pins bumped by Dependabot.
This was referenced Nov 5, 2026
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
|
||
| - name: Ensure tag | ||
| uses: aragon/github-templates/steps/gh-ensure-tag@main | ||
| uses: aragon/github-templates/steps/gh-ensure-tag@v1 |
|
|
||
| - name: Ensure GitHub Release | ||
| uses: aragon/github-templates/steps/gh-ensure-release@main | ||
| uses: aragon/github-templates/steps/gh-ensure-release@v1 |
jjavieralv
approved these changes
Nov 6, 2026
jjavieralv
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I precreated the tag v1 on f387185 to let the system run it first iteration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consumers move from
@mainto the moving major tag@v1(APP-1344, the model agreed in #23: a fix keeps reaching every repo at once, a breaking change ships asv2that each repo adopts in its own PR). This PR makes the repo itself follow that model.Changes
@v1instead of@main, so av1consumer never runsv2code and the released line does not follow unreleased changes. The next major rewrites them to@v2.release-selfnever moves a major tag backwards. The new cut must descend from wherevNpoints.lib/selfReferences.test.jsfails on a self-reference that is not a major tag, or on two majors at once.docs/release-design.md§6–7,contracts/README.md,examples/README.md,dependabot.yml) describe the@v1model instead of SHA pins bumped by Dependabot.Rollout
v1at the currentmain(f387185) by hand:git tag v1 f387185 && git push origin v1. Then@v1resolves to exactly the code the consumers run@maintoday, this PR's workflows are runnable once merged, and the consumer PRs (aragon/app, aragon/app-backend, aragon/aragon-indexer) are green independently of this merge.release-selfwithv1.0.0onmain:v1moves to the first self-consistent cut.actions/unpinned-tagCodeQL alerts in the consumers with the README rationale.🤖 Generated with Claude Code