Skip to content

feat: reference the modules through the moving major tag - #26

Merged
jjavieralv merged 1 commit into
mainfrom
feat/v1-major-tag
Nov 6, 2026
Merged

jjavieralv merged 1 commit into
mainfrom
feat/v1-major-tag

Conversation

@tyhonchik

Copy link
Copy Markdown
Contributor

The consumers move from @main to the moving major tag @v1 (APP-1344, the model agreed in #23: a fix keeps reaching every repo at once, a breaking change ships as v2 that each repo adopts in its own PR). This PR makes the repo itself follow that model.

Changes

  • Self-references on the major tag. The reusable workflows and the examples reference the composite actions and each other @v1 instead of @main, so a v1 consumer never runs v2 code and the released line does not follow unreleased changes. The next major rewrites them to @v2.
  • release-self never moves a major tag backwards. The new cut must descend from where vN points.
  • lib/selfReferences.test.js fails on a self-reference that is not a major tag, or on two majors at once.
  • Docs (README "Versioning", docs/release-design.md §6–7, contracts/README.md, examples/README.md, dependabot.yml) describe the @v1 model instead of SHA pins bumped by Dependabot.

Rollout

  1. Bootstrap v1 at the current main (f387185) by hand: git tag v1 f387185 && git push origin v1. Then @v1 resolves to exactly the code the consumers run @main today, this PR's workflows are runnable once merged, and the consumer PRs (aragon/app, aragon/app-backend, aragon/aragon-indexer) are green independently of this merge.
  2. Merge, then dispatch release-self with v1.0.0 on main: v1 moves to the first self-consistent cut.
  3. Dismiss the actions/unpinned-tag CodeQL alerts in the consumers with the README rationale.

🤖 Generated with Claude Code

The reusable workflows and the examples reference the composite actions
and each other @v1, the tag the consumers point at, so a v1 consumer never
runs v2 code; release-self refuses to move a major tag backwards and a test
keeps every self-reference on one major. Docs describe the @v1 model instead
of SHA pins bumped by Dependabot.

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.


- name: Ensure tag
uses: aragon/github-templates/steps/gh-ensure-tag@main
uses: aragon/github-templates/steps/gh-ensure-tag@v1

- name: Ensure GitHub Release
uses: aragon/github-templates/steps/gh-ensure-release@main
uses: aragon/github-templates/steps/gh-ensure-release@v1
Comment thread .github/workflows/release-finalize.yml Dismissed
Comment thread .github/workflows/release-finalize.yml Dismissed
Comment thread .github/workflows/release-pr-refresh.yml Dismissed
Comment thread .github/workflows/release-start.yml Dismissed
Comment thread .github/workflows/release-start.yml Dismissed
Comment thread .github/workflows/release-start.yml Dismissed
Comment thread .github/workflows/release-start.yml Dismissed
Comment thread .github/workflows/release-start.yml Dismissed

@jjavieralv jjavieralv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I precreated the tag v1 on f387185 to let the system run it first iteration

@jjavieralv
jjavieralv merged commit 2bc9781 into main Nov 6, 2026
4 checks passed
@jjavieralv
jjavieralv deleted the feat/v1-major-tag branch November 6, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants