Repository navigation
Conversation
Use the Angular notebook connection and authentication lifecycle in the React Assistant. Keep notebook paragraph rendering at the workspace composition boundary and expose generic answer rendering to the conversation panel. Cover session retirement, notebook isolation, authentication handling, and saved and streaming answer rendering with unit tests.
Mock Assistant REST and WebSocket traffic in Playwright while retaining the real notebook and authentication host. Replace the production fixture flag with test-owned wire responses and explicit streaming completion gates. Exercise saved history, streaming completion, notebook isolation, and paginated answer merging without an external LLM.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Replace the fixture-backed notebook Assistant flow with the existing conversation REST API and WebSocket transport. Users can create, select, and delete conversations, load saved history, and submit questions from the notebook sidebar.
The Angular host provides the notebook connection and authentication handling to the React panel. Requests and subscriptions are scoped to the open panel and current notebook session. Paragraph references in answers use the notebook’s existing selection and scrolling behavior.
What type of PR is it?
Feature
What is the Jira issue?
How should this be tested?
With Zeppelin running, set
PLAYWRIGHT_BASE_URLto the server address. If authentication is enabled, setZEPPELIN_E2E_SHIRO_INIto the server’s Shiro configuration. Fromzeppelin-web-angular, run:Verify conversation creation and submission, streamed answer completion, history restoration, conversation isolation, and loading earlier messages. The tests mock Assistant REST/WebSocket responses while using the running server for notebook and authentication traffic.
For an existing conversation, delay or fail its initial history request. The draft should remain editable, and sending should become available only after a successful history retry, without automatic submission. New local conversations and history requests after initial success should remain unaffected.
Questions: