Skip to content

[core] Preserve deletion vector changes in snapshot diffs - #11258

Open
zhangyue19921010 wants to merge 1 commit into
apache:masterfrom
zhangyue19921010:contrib/preserve-dv-changes-in-snapshot-diffs
Open

zhangyue19921010 wants to merge 1 commit into
apache:masterfrom
zhangyue19921010:contrib/preserve-dv-changes-in-snapshot-diffs

Conversation

@zhangyue19921010

Copy link
Copy Markdown
Contributor

Purpose

Primary-key snapshot diffs can miss deletes recorded only in deletion vectors: the planner removes a shared data file from both sides even though its visible rows changed. They can also report an update whose value did not change.

Compare the deletion-file descriptors before pruning shared files from primary-key diffs. Files whose descriptors are unchanged remain pruned.

Fixes #11257

Tests

Six real-table cases cover audit-log deletes, repeated vector changes, changed and unchanged values, unchanged-vector file pruning, and a non-DV control. On unchanged master, three regressions fail and three controls pass; all six pass with the patch.

All 23 selected table, timestamp-incremental, snapshot-reader, streaming follow-up, and audit-log tests pass on JDK 11 with normal Maven verify, including Checkstyle, Spotless, Enforcer, and RAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Primary-key snapshot diffs miss deletion vector changes

1 participant