Repository navigation
[core] Preserve deletion vector changes in snapshot diffs - #11258
Open
zhangyue19921010 wants to merge 1 commit into
Open
zhangyue19921010 wants to merge 1 commit into
zhangyue19921010 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Primary-key snapshot diffs can miss deletes recorded only in deletion vectors: the planner removes a shared data file from both sides even though its visible rows changed. They can also report an update whose value did not change.
Compare the deletion-file descriptors before pruning shared files from primary-key diffs. Files whose descriptors are unchanged remain pruned.
Fixes #11257
Tests
Six real-table cases cover audit-log deletes, repeated vector changes, changed and unchanged values, unchanged-vector file pruning, and a non-DV control. On unchanged master, three regressions fail and three controls pass; all six pass with the patch.
All 23 selected table, timestamp-incremental, snapshot-reader, streaming follow-up, and audit-log tests pass on JDK 11 with normal Maven
verify, including Checkstyle, Spotless, Enforcer, and RAT.