Repository navigation
[core] Deduplicate initial listagg tokens - #11256
Open
zhangyue19921010 wants to merge 1 commit into
Open
zhangyue19921010 wants to merge 1 commit into
zhangyue19921010 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Distinct listagg retains duplicate tokens from the first input: merging
"a,a"and"b"produces"a,a,b", including after full compaction. Normalize the accumulator before appending unseen tokens, including when partial-update sequence groups reverse the inputs. Keep non-distinct and empty-delimiter behavior unchanged.Fixes #11255
Tests
PrimaryKeyListaggDistinctTestcovers aggregation and partial-update tables, same/separate commits, custom delimiters, reversed sequence groups, and full compaction, with non-distinct and empty-delimiter controls.On unchanged master
79b8ec4788, 12 regression cases fail and 6 compatibility controls pass. With this change, all 38 selected table, listagg, and partial-update tests pass on JDK 11. Normal Mavenverifyalso passes Checkstyle, Spotless, Enforcer, and RAT.