Repository navigation
Conversation
Selected masks and lookup hits alone miss historical rows restored by concurrent index changes. Check intervening COMPACT and OVERWRITE snapshots in the same partition and bucket, including CAS retries. Recover overwrite compaction using current deletion vectors and surviving original L0 inputs so later writes retain their lookup changelogs. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Existing input-mask and lookup-hit checks miss historical rows restored by an index-only overwrite, allowing stale PK DV compaction to commit. Overwrite recovery also skipped surviving inputs after partial replacement, leaking suppressed changelogs.
Brief change log
Tests
561 focused tests passed. CI-pinned formatting and workspace Clippy with vortex passed.
API and Format
No public API or storage format changes.
Documentation
Updated compaction conflict and recovery behavior.