Skip to content

fix(table): reject stale same-bucket PK DV compaction - #1454

Open
QuakeWang wants to merge 1 commit into
apache:mainfrom
QuakeWang:pk-dv-compaction-conflicts
Open

QuakeWang wants to merge 1 commit into
apache:mainfrom
QuakeWang:pk-dv-compaction-conflicts

Conversation

@QuakeWang

Copy link
Copy Markdown
Member

Purpose

Existing input-mask and lookup-hit checks miss historical rows restored by an index-only overwrite, allowing stale PK DV compaction to commit. Overwrite recovery also skipped surviving inputs after partial replacement, leaking suppressed changelogs.

Brief change log

  • Check intervening COMPACT and OVERWRITE snapshots by partition and bucket, including CAS retries.
  • Recover with current DVs and surviving original L0 inputs, preserving later writes' changelogs.

Tests

561 focused tests passed. CI-pinned formatting and workspace Clippy with vortex passed.

API and Format

No public API or storage format changes.

Documentation

Updated compaction conflict and recovery behavior.

Selected masks and lookup hits alone miss historical rows restored by
concurrent index changes. Check intervening COMPACT and OVERWRITE
snapshots in the same partition and bucket, including CAS retries.

Recover overwrite compaction using current deletion vectors and surviving
original L0 inputs so later writes retain their lookup changelogs.

Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant