Repository navigation
[build] Allow opting into rustls for Paimon HTTP clients - #1453
Open
naivedogger wants to merge 1 commit into
Open
naivedogger wants to merge 1 commit into
naivedogger wants to merge 1 commit into
Conversation
Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 25/25 AI-Contributed/UT: 0/0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #1451.
Paimon currently enables reqwest’s default TLS backend, which can introduce an OpenSSL build dependency on Linux. Making the backend selectable allows downstream crates to use rustls for Paimon’s HTTP clients as well.
Brief change log
Expose
native-tls(default) andrustlsas Cargo features. The rustls backend uses system certificate roots. Existing non-TLS reqwest features are retained.Tests
Checked the Linux dependency graph with
cargo tree: the default build includesopenssl-sys; the build with--no-default-features --features rustlsdoes not.API and Format
Default builds retain native TLS. Applications that already set
default-features = falseand rely on HTTPS must explicitly enablenative-tlsorrustlswhen upgrading. Cargo features are additive, so another dependency can still enable native TLS for the same reqwest version.Documentation
The getting-started guide includes a rustls configuration and the migration note for applications that disable default features.