Skip to content

chore(nsh): sync rust-preview with upstream 0.6.1 - #7145

Open
me2seeks wants to merge 7 commits into
rust-previewfrom
chore/nsh-0.6.1
Open

me2seeks wants to merge 7 commits into
rust-previewfrom
chore/nsh-0.6.1

Conversation

@me2seeks

Copy link
Copy Markdown
Contributor

Summary

Sync the vendored NSH runtime from 80b17ee2 (0.6.0) to longbridge/nsh v0.6.1 at 2f51d861.

The v0.6.1 tag is on a cherry-picked release line that does not contain every mainline fix already present in our 0.6.0 baseline. This PR therefore merges the release with that baseline in four reviewable rounds instead of replacing the tree and reverting those fixes.

The update includes:

  • Correct cancellation of pending composite animations when values are stopped, set, released or replaced.
  • Explicit missing-feature diagnostics, optional SVG asset validation and native updater errors.
  • Windows 11 backdrop support through windows={{ backdrop: { material: "blur" } }}.
  • Video state, hidden-window, screenshot-memory, carousel, resizable, fixed-table-column and mobile layout/lifecycle fixes.

Maka's terminal transport and embedding, source-aware reading, and Windows deferred first-show focus remain in place. Cargo locks, source provenance, the binary-fixture audit and distribution notices are updated for 0.6.1.

Breaking changes

  • SVG assets with the feature disabled now fail the native build. With default-features = false and no svg feature, asset!("…svg") or an assets!() directory containing SVG emits a compile error naming the required platform feature. Previously the app could build and only lose the image at runtime. Web remains exempt because the browser renders SVG. Maka enables svg, so no Maka migration is needed.
  • Native updater checks now reject when the feature is disabled. Without updater, checkForUpdate and checkForPackage reject with ERR_FEATURE_UNAVAILABLE_ON_PLATFORM instead of reporting no update indefinitely. Web behavior is unchanged. Maka enables updater, so its existing update flow is unaffected.

No removal of an existing public Rust or TS API was found in the reviewed diff. The Windows backdrop types and windows view prop are additive.

Verification

  • mbx check -p maka-terminal-shell -p maka-workbench -p maka-desktop-shell --tests passed after merging the latest rust-preview.
  • mbx test -p nsh-core -p nsh-base -p nsh-js -p nsh-engine --lib: 3,302 passed, 0 failed, 27 ignored.
  • mbx test -p nsh-macros: 21 passed, 0 failed, 3 ignored.
  • node --test crates/nsh-platform-web/web/nsh.test.mjs crates/nsh-platform-web/web/browser/reactive.test.mjs: 163 passed, 0 failed, 44 skipped because they require a Wasm fixture.
  • Six focused Maka workbench tests passed: desktop and terminal streaming, three Markdown integration tests, and Markdown source positions through CJK/emoji.
  • node scripts/rust/notices.mjs check and node scripts/asf-license-headers.mjs check passed.
  • git diff --check origin/rust-preview...HEAD passed.

Native Windows, iOS and Android interaction was not exercised locally. Nightly rustfmt could not be downloaded because of a TLS failure; stable rustfmt reports one formatting difference in the upstream transparent.rs. cargo-deny is not installed, so dependencies.mjs check was not run; the lockfile changes only nsh path-crate versions, with no external dependency changes.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Maka performed the staged upstream merge, reconciled Maka's retained changes, reviewed breaking changes and ran verification. Material commits carry Generated-by: Maka trailers.

Checklist

  • Tests cover the change and fail without it
  • Format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary and Breaking changes above
  • No

Merge the 0.6.1 release-line platform fixes with the existing 0.6.0 mainline baseline. Retain terminal integration and deferred first-show focus on Windows.

Generated-by: Maka
Pick up carousel disposal, iOS transformed safe-area, Android edge-pull, system-bar and RTL fixes.

Generated-by: Maka
Keep SVG optional while making missing SVG support explicit for bundled assets and runtime loads. Retain Maka terminal feature wiring.

Generated-by: Maka
Merge longbridge/nsh v0.6.1 at 2f51d861 with the prior mainline baseline. Add Windows backdrop support, explicit missing-feature errors, and composite-animation cancellation while retaining Maka embedding and terminal adaptations.

Generated-by: Maka

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant