Repository navigation
Conversation
Merge the 0.6.1 release-line platform fixes with the existing 0.6.0 mainline baseline. Retain terminal integration and deferred first-show focus on Windows. Generated-by: Maka
Pick up carousel disposal, iOS transformed safe-area, Android edge-pull, system-bar and RTL fixes. Generated-by: Maka
Keep SVG optional while making missing SVG support explicit for bundled assets and runtime loads. Retain Maka terminal feature wiring. Generated-by: Maka
Merge longbridge/nsh v0.6.1 at 2f51d861 with the prior mainline baseline. Add Windows backdrop support, explicit missing-feature errors, and composite-animation cancellation while retaining Maka embedding and terminal adaptations. Generated-by: Maka
Generated-by: Maka
Generated-by: Maka
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync the vendored NSH runtime from
80b17ee2(0.6.0) to longbridge/nsh v0.6.1 at2f51d861.The v0.6.1 tag is on a cherry-picked release line that does not contain every mainline fix already present in our 0.6.0 baseline. This PR therefore merges the release with that baseline in four reviewable rounds instead of replacing the tree and reverting those fixes.
The update includes:
windows={{ backdrop: { material: "blur" } }}.Maka's terminal transport and embedding, source-aware reading, and Windows deferred first-show focus remain in place. Cargo locks, source provenance, the binary-fixture audit and distribution notices are updated for 0.6.1.
Breaking changes
default-features = falseand nosvgfeature,asset!("…svg")or anassets!()directory containing SVG emits a compile error naming the required platform feature. Previously the app could build and only lose the image at runtime. Web remains exempt because the browser renders SVG. Maka enablessvg, so no Maka migration is needed.updater,checkForUpdateandcheckForPackagereject withERR_FEATURE_UNAVAILABLE_ON_PLATFORMinstead of reporting no update indefinitely. Web behavior is unchanged. Maka enablesupdater, so its existing update flow is unaffected.No removal of an existing public Rust or TS API was found in the reviewed diff. The Windows backdrop types and
windowsview prop are additive.Verification
mbx check -p maka-terminal-shell -p maka-workbench -p maka-desktop-shell --testspassed after merging the latestrust-preview.mbx test -p nsh-core -p nsh-base -p nsh-js -p nsh-engine --lib: 3,302 passed, 0 failed, 27 ignored.mbx test -p nsh-macros: 21 passed, 0 failed, 3 ignored.node --test crates/nsh-platform-web/web/nsh.test.mjs crates/nsh-platform-web/web/browser/reactive.test.mjs: 163 passed, 0 failed, 44 skipped because they require a Wasm fixture.node scripts/rust/notices.mjs checkandnode scripts/asf-license-headers.mjs checkpassed.git diff --check origin/rust-preview...HEADpassed.Native Windows, iOS and Android interaction was not exercised locally. Nightly rustfmt could not be downloaded because of a TLS failure; stable rustfmt reports one formatting difference in the upstream
transparent.rs.cargo-denyis not installed, sodependencies.mjs checkwas not run; the lockfile changes only nsh path-crate versions, with no external dependency changes.AI use
Tool(s) and scope: Maka performed the staged upstream merge, reconciled Maka's retained changes, reviewed breaking changes and ran verification. Material commits carry
Generated-by: Makatrailers.Checklist
Does this PR entail a change in behavior?