Repository navigation
fix(agent): support external executors for Goals - #7142
Merged
Merged
Conversation
Generated-by: Maka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goal creation and resume rejected external executors such as agy because the UI approval path still required a native model, even though Goal dispatch and persistence already supported external Agents.
BackendPreferencethroughGoalApprovaland the generated SDK contracts.Verification
cargo test -p maka-cli --test external_jobs antigravity_goal_resumes_after_stop_with_ui_approval— passed; agy creates a Goal, stops, resumes on the same ACP thread, and achieves it in two iterations.cargo test -p maka-cli --test external_jobs antigravity_automation_wakes_the_original_conversation_after_the_turn— passed.cargo test -p maka-cli --test producer_reopen goal— 3 native-model Goal tests passed.node --test products/maka/workbench/tests/session-goal.test.mjs— 6 tests passed.npm --workspace @maka-agent/plugin-sdk run schema:check— 5 generated declaration files verified.Full workspace CI was not run locally.
AI use
Select exactly one:
Tool(s) and scope: Maka implemented the contract and UI changes, added the regression coverage, and ran the verification above.
Checklist
Does this PR entail a change in behavior?