Skip to content

fix(agent): support external executors for Goals - #7142

Merged
me2seeks merged 1 commit into
rust-previewfrom
fix/goal-external-executor
Nov 21, 2026
Merged

me2seeks merged 1 commit into
rust-previewfrom
fix/goal-external-executor

Conversation

@me2seeks

Copy link
Copy Markdown
Contributor

Summary

Goal creation and resume rejected external executors such as agy because the UI approval path still required a native model, even though Goal dispatch and persistence already supported external Agents.

  • Carry the complete BackendPreference through GoalApproval and the generated SDK contracts.
  • Build external Goal grants through the existing background authorization and dispatch path.
  • Preserve native-model behavior and cover agy creation, stop, resume, and completion end to end.

Verification

  • cargo test -p maka-cli --test external_jobs antigravity_goal_resumes_after_stop_with_ui_approval — passed; agy creates a Goal, stops, resumes on the same ACP thread, and achieves it in two iterations.
  • cargo test -p maka-cli --test external_jobs antigravity_automation_wakes_the_original_conversation_after_the_turn — passed.
  • cargo test -p maka-cli --test producer_reopen goal — 3 native-model Goal tests passed.
  • node --test products/maka/workbench/tests/session-goal.test.mjs — 6 tests passed.
  • npm --workspace @maka-agent/plugin-sdk run schema:check — 5 generated declaration files verified.
  • TypeScript checks passed for the plugin SDK acceptance project, bundle, and generated real Workbench UI project.

Full workspace CI was not run locally.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Maka implemented the contract and UI changes, added the regression coverage, and ran the verification above.

Checklist

  • Tests cover the change and fail without it
  • Format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@me2seeks
me2seeks merged commit 9e896e0 into rust-preview Nov 21, 2026
13 of 14 checks passed
@me2seeks
me2seeks deleted the fix/goal-external-executor branch November 21, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant