Repository navigation
feat(peer-mesh): add signed mesh control plane, A->C->B transit relay, and hedged dialer - #7138
Conversation
…, and hedged dialer
There was a problem hiding this comment.
Correction: I am withdrawing the lease-lifetime finding from this review. Main's production Peer Mesh intentionally retains expired reachability leases as bounded recovery hints for up to 24 hours and includes them in ordinary route resolution. The reviewed Rust implementation matches that contract. I found no remaining P0–P2 issue in this PR at e8b45cfc74abe956132a9a33561fd47088c156cf.
Automated review notice: This comment was posted by an automated review agent operated by jackwener. It is not an independent human review and does not replace one.
| let root_id = target_ad.advertisement().reachability_lease().lease().root_id(); | ||
| if let Some(usable) = self | ||
| .leases | ||
| .resolve_usable_at(root_id, target_peer_id, now_ms, monotonic_now) |
There was a problem hiding this comment.
Withdrawn after comparing this stack with main's production Peer Mesh.
This review point was incorrect. Main deliberately retains expired reachability leases as bounded recovery hints for up to 24 hours, and PeerMeshNode.resolveRoutes() calls latestReachability(..., includeHistorical = true). This implementation matches that existing contract, so I am withdrawing the requested change. Sorry for the incorrect finding.
Stack A: P2P Mesh (Stacked PRs)
stack/p2p-mesh-1-accept-remote-streamsrust-previewstack/p2p-mesh-2-peer-identity-and-reachabilitystack/p2p-mesh-1-accept-remote-streamsstack/p2p-mesh-3-mesh-control-and-transitstack/p2p-mesh-2-peer-identity-and-reachabilitystack/p2p-mesh-4-cli-and-pairing-ticketstack/p2p-mesh-3-mesh-control-and-transitIntroduce
platform/peer-mesh(maka-peer-mesh) implementing the owner-signed mesh roster,A -> C -> Btransit policy & stream bridging, and 250ms hedged dialing with faster transit promotion.Changes
platform/peer-mesh/src/roster.rs:SignedPeerMeshRosterV1,SignedPeerMeshMemberAdvertisementV1, owner-pinned monotonicMeshStateStore, and route candidate selection (RTT(A, C) + RTT(C, B) < RTT(A, B)).platform/peer-mesh/src/transit.rs: fail-closedTransitPolicy(explicit owner/member authorization, optionalNonZeroUsizecircuit cap with RAIITransitCircuitGuard) andbridge_transit_streams.platform/peer-mesh/src/dialer.rs:hedged_dialattempting directA -> Bfirst and hedging to approvedA -> C -> Bmesh transit after 250ms.platform/peer-mesh/tests/mesh_behaviors.rs: real end-to-endHost::serve_remote+ Relay Cbridge_transit_streams+hedged_dial+ResumablePeerStreamupgrade & owner-revocation eviction tests.Verification
cargo test --locked -p maka-peer-mesh(2/2 pass)node scripts/asf-license-headers.mjs check(pass)