Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19125 +/- ##
============================================
- Coverage 48.29% 48.28% -0.01%
Complexity 625 625
============================================
Files 5572 5576 +4
Lines 411719 411943 +224
Branches 54229 54271 +42
============================================
+ Hits 198820 198924 +104
- Misses 212899 213019 +120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Allow callers on the trusted cluster network to reuse the existing client session protocol through the DataNode internal RPC endpoint. Internal callers can run queries and writes under an existing user's identity without maintaining a separate query protocol or using an ingress account.
RPC and session lifecycle
IDataNodeRPCServiceextendIClientRPCServiceand inherit its Java implementation.showConfigurationInternalandinsertRecordInternal, preserving their distinct behavior and updating ConfigNode callers.Identity and clients
IInternalSessionBuilder<T>andbuildInternal(INodeSupplier)entry points for tree sessions, table sessions, and table subscription-management sessions.INodeSupplier; disable external discovery and endpoint redirection for internal sessions. Reuse existing session connections and result sets.Compatibility and trust boundary
Username-only login is available exclusively through the trusted DataNode internal endpoint; it is not a client-facing authentication option. This change inherits the full client RPC surface and is not restricted to read-only queries. Existing CN/DN internal callers must use the renamed configuration and audit-write RPCs. Subscription Pull/Push consumers and connection pools are not adapted in this change.
Validation
git diff --check.Key changed/added classes
IDataNodeRPCService,DataNodeInternalRPCServiceImpl,ClientRPCServiceImpl,SessionManager,InternalServiceThriftHandler,IInternalSessionBuilder,InternalSession, andInternalSubscriptionTableSession.