Skip to content

Fix equality hash code contracts - #17890

Open
Caideyipi wants to merge 4 commits into
masterfrom
fix-equals-hashcode-contract-master
Open

Caideyipi wants to merge 4 commits into
masterfrom
fix-equals-hashcode-contract-master

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary: Fix several equals/hashCode contract mismatches in Binary, MetricInfo, NodeStatistics, User, pipe plugin/task meta, and trigger metadata. Add focused regression tests. Tests: BinaryTest, MetricInfoTest, node-commons targeted tests, and NodeStatisticsTest passed locally.

@codecov

codecov Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.42%. Comparing base (a8497be) to head (c82131c).
⚠️ Report is 128 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17890      +/-   ##
============================================
+ Coverage     43.40%   43.42%   +0.01%     
- Complexity      374      387      +13     
============================================
  Files          5366     5366              
  Lines        382885   382873      -12     
  Branches      49796    49794       -2     
============================================
+ Hits         166187   166255      +68     
+ Misses       216698   216618      -80     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…-contract-master

# Conflicts:
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/meta/PipeTemporaryMetaInAgent.java
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant