Repository navigation
Add httpclient5-bom module - #937
garydgregory wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open issues
What changed in this PR
Adds a new Maven BOM module to centrally manage versions for the HttpClient 5 artifact set.
Changes:
- Adds
httpclient5-bomto the reactor build. - Introduces a new
httpclient5-bomPOM that manages versions for eightorg.apache.httpcomponents.client5artifacts.
| File | Description |
|---|---|
| pom.xml | Adds the new BOM module to the multi-module build. |
| httpclient5-bom/pom.xml | Defines the BOM (packaging=pom) and its managed artifact list. |
Review effort: Lite
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpcomponents-parent</artifactId> | ||
| <version>15</version> | ||
| <relativePath/> | ||
| </parent> | ||
| <groupId>org.apache.httpcomponents.client5</groupId> | ||
| <artifactId>httpclient5-bom</artifactId> | ||
| <version>5.7-beta2-SNAPSHOT</version> |
| <packaging>pom</packaging> | ||
| <name>Apache HttpComponents Client BOM</name> | ||
| <description>Bill of Materials for Apache HttpComponents Client</description> | ||
| <url>https://hc.apache.org/httpcomponents-client-5.7.x/${project.version}/</url> |
ebc2246 to
77dbb9b
Compare
Provide dependency management for all eight HttpClient artifacts. See also https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html
77dbb9b to
e86d272
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
5 open issues
minimalJavaBuildVersionis set to 17 whilejavaVersion/ compiler source+target are set to 8.… · New<module>httpclient5-bom</module>), but it does not… · Newurlfield in published POM metadata should ideally be stable and resolvable. Using…http://URLs. While typically not fetched during normal… · New
Review effort: Lite
| <properties> | ||
| <javaVersion>8</javaVersion> | ||
| <minimalJavaBuildVersion>17</minimalJavaBuildVersion> | ||
| <maven.compiler.source>${javaVersion}</maven.compiler.source> | ||
| <maven.compiler.target>${javaVersion}</maven.compiler.target> | ||
| <!-- A BOM has no bytecode to check. --> | ||
| <animal.sniffer.skip>true</animal.sniffer.skip> | ||
| </properties> |
| <parent> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpcomponents-parent</artifactId> | ||
| <version>15</version> | ||
| <relativePath/> | ||
| </parent> | ||
| <groupId>org.apache.httpcomponents.client5</groupId> | ||
| <artifactId>httpclient5-bom</artifactId> | ||
| <version>5.7-beta2-SNAPSHOT</version> |
| information on the Apache Software Foundation, please see | ||
| <http://www.apache.org />. | ||
| --> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> |
| <parent> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpcomponents-parent</artifactId> | ||
| <version>15</version> |
There was a problem hiding this comment.
@garydgregory Is there a reason the parent of this module has to be org.apache.httpcomponents:httpcomponents-parent and not the project parent httpclient5-parent?
There was a problem hiding this comment.
I was trying to follow https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#bill-of-materials-bom-poms but our POMs are not set up that way currently. Making it as you suggest might create a circular dependency. I'll try it.
There was a problem hiding this comment.
@garydgregory You do not have to. I just wanted to know if that had been intentional.
ok2c
left a comment
ok2c
left a comment
There was a problem hiding this comment.
@garydgregory You need to pacify Copilot but otherwise looks OK to me.
Please do make a symmetric change to core as well.
Provide dependency management for all eight HttpClient artifacts.
See also https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html