Repository navigation
revertSnapshot fails with an NPE when the snapshot's volume has been deleted #14644
Description
problem
revertSnapshot fails with a NullPointerException when the snapshot's volume has been deleted:
Cannot invoke "com.cloud.storage.VolumeVO.getState()" because "volume" is null
at com.cloud.storage.snapshot.SnapshotManagerImpl.revertSnapshot
SnapshotManagerImpl.revertSnapshot looks the volume up with findById(), which does not return removed volumes, and uses the result without a null check. Volume snapshots outlive their volume, so any snapshot of a deleted volume hits this. The caller gets an internal error instead of being told why the snapshot cannot be reverted.
A few other snapshot APIs have the same gap:
copySnapshotwithoutsourcezoneidtakes the source zone from the volume, also looked up withfindById(). For a snapshot of a deleted volume it fails withCannot invoke "com.cloud.storage.Volume.getDataCenterId()" because "volume" is null. The copy itself does not need the volume, and the same copy works whensourcezoneidis passed.createVolumefrom a snapshot andcreateTemplatefrom a snapshot look the volume up including removed rows, so a deleted volume is fine. They still NPE when the volume row itself is gone (parentVolume.getPassphraseId()inVolumeApiServiceImpl.allocVolume; forcreateTemplate, the template record is created and the job then fails inTemplateManagerImpl.createPrivateTemplate). A missing row is the case in listSnapshots fails with NPE in snapshot strategy canHandle when a snapshot's volume row no longer exists #14599.
versions
4.22, and main.
The steps to reproduce the bug
- Create a data volume, attach it to a VM, and take a volume snapshot of it.
- Detach and delete the volume. The snapshot remains.
- Call
revertSnapshot id=<snapshot>. It fails with the NPE above. - Call
copySnapshot id=<snapshot> destzoneids=<another zone>withoutsourcezoneid. It fails with thegetDataCenterId()NPE.
For createVolume snapshotid= and createTemplate snapshotid=, the volume row has to be missing from the volumes table.
What to do about it?
revertSnapshot: refuse with a clear error when the snapshot's volume no longer exists.copySnapshot: when the volume is gone, take the source zone from the snapshot, which records the zone it was taken in.createVolumeandcreateTemplatefrom a snapshot: refuse with a clear error when the volume row is missing, instead of failing with an NPE.
Activity
Refuse snapshot operations cleanly when the volume is gone
Refuse snapshot operations cleanly when the volume is gone
github-actions commentedon Nov 11, 2026
Warning
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.
What happened
The threat detection engine failed to produce results.
Review the workflow run logs for details.
🎯 Triage report
revertSnapshotfails with an NPE when the snapshot's volume has been deleted.SnapshotManagerImpl.revertSnapshotlooks the volume up withfindById(), which excludes removed rows, and then uses the result without a null check. The reporter also found thatcopySnapshotwithoutsourcezoneidhits the same NPE, and thatcreateVolumeandcreateTemplatefrom a snapshot NPE when the volume row is missing entirely. The proposed fixes are a clear error for revert and create, and taking the source zone from the snapshot for copy.📊 Assessment
🔗 Similar issues
canHandle()when the volume row is missing💡 Notes and suggestions
revertSnapshotandcopySnapshotwithoutsourcezoneid.createVolumeandcreateTemplatefrom a snapshot only fail when the volume row is gone, which is a different case from a removed volume. Check both.Add this agentic workflow to your repo
To install this agentic workflow, run