Repository navigation
fix(docs): make animation controls keyboard accessible - #1939
Open
nemo-crypto wants to merge 1 commit into
Open
nemo-crypto wants to merge 1 commit into
nemo-crypto wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animation names in the documentation playground are clickable spans, so keyboard users cannot focus or activate them. Copy controls are also hidden unless the row is hovered, and their focus outline is removed.
Render animation names as native
type="button"controls while preserving their current appearance and click delegation. Reveal the copy control when its row contains keyboard focus, expose its tooltip on focus, and give both controls a visible keyboard focus outline. Update the generator and generated page together.Validation:
tests/keyboard-controls.jspasses in Chromium, Firefox and WebKit at 1280px, 768px and 390px: keyboard traversal, Enter/Space playback, focus visibility, copying the selected class, and existing pointer playback. Clipboard writes are mocked; the system clipboard is not modified.npm run docs:pages, checked desktop/mobile-width screenshots, and rangit diff --check.These are browser viewport simulations, not physical-device or screen-reader tests. To run the optional test, install
@playwright/testand its browsers, then runnode tests/keyboard-controls.js.