Repository navigation
Fix Glance canonical layout samples - #513
Merged
Merged
Conversation
ashnohe
requested review from
alabiaga,
madebymozart and
yrezgui
as code owners
November 16, 2026 22:06
ashnohe
requested review from
MayuriKhinvasara and
TKBurner
and removed request for
alabiaga and
madebymozart
November 16, 2026 22:06
alabiaga
reviewed
Nov 16, 2026
| import androidx.compose.foundation.layout.size | ||
| import androidx.compose.foundation.lazy.LazyColumn | ||
| import androidx.compose.foundation.lazy.items | ||
| import androidx.compose.foundation.text.ClickableText |
Member
There was a problem hiding this comment.
Interesting that ClickableText was used in the initial change when it was a deprecated API. Is it because of the SKILL that references a usage of it? That is being updated as well?
Contributor
Author
There was a problem hiding this comment.
The SKILL is essentially a copy of this so it does reference it and +1 the skill was updated as well to reflect this
TKBurner
approved these changes
Nov 18, 2026
|
El lun, 16 de nov de 2026, 4:07 p.m., Ash ***@***.***>
escribió:
… ------------------------------
You can view, comment on, or merge this pull request online at:
#513
Commit Summary
- 2ed5cc8
<2ed5cc8>
Fix Glance canonical layout samples
File Changes
(3 files <https://github.com/android/platform-samples/pull/513/files>)
- *M*
samples/user-interface/appwidgets/src/main/java/com/example/platform/ui/appwidgets/glance/layout/CanonicalLayoutActivity.kt
<https://github.com/android/platform-samples/pull/513/files#diff-59e37c6d3b6fcb9ddd65126e9a112dd1597d3249b2abdcf5b5f326c5595568af>
(32)
- *M*
samples/user-interface/appwidgets/src/main/java/com/example/platform/ui/appwidgets/glance/layout/collections/data/FakeImageTextListDataRepository.kt
<https://github.com/android/platform-samples/pull/513/files#diff-ccd3bc5fffefb670c34ef1642300d885a66853bbc3122802e5988d923e47f36e>
(4)
- *M*
samples/user-interface/appwidgets/src/main/java/com/example/platform/ui/appwidgets/glance/layout/utils/ImageAspectRatio.kt
<https://github.com/android/platform-samples/pull/513/files#diff-0c58005134ecf6890fe0bf3418322d0e26b9c8eddee53f0a390593c8d82e80e7>
(4)
Patch Links:
- https://github.com/android/platform-samples/pull/513.patch
- https://github.com/android/platform-samples/pull/513.diff
—
Reply to this email directly, view it on GitHub
<#513?email_source=notifications&email_token=B7Y2SOIR77IU6BHZJ65HUQT5ZN3CFA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF42TGNBWGA2DCNZVGWTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVRTG633UMVZF6Y3MNFRWW>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B7Y2SOKXF4EWECCYQA4SD2L5ZN3CFAVCNFSNUABFKJSXA33TNF2G64TZHM3DEMZTGM3DSNRSHNEXG43VMU5TMNBTGE4DINBYGQZKC5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.