Skip to content

chore(AIP-121): fix unclear output only steady-state sentence - #1682

Merged
noahdietz merged 1 commit into
aip-dev:masterfrom
Amila-Rukshan:fix/aip-121-steady-state-wording
Nov 17, 2026
Merged

noahdietz merged 1 commit into
aip-dev:masterfrom
Amila-Rukshan:fix/aip-121-steady-state-wording

Conversation

@Amila-Rukshan

Copy link
Copy Markdown
Contributor

Remove a leftover sentence fragment that made the guidance on output only values self-contradictory. Output only values related to the resource state are covered by the later paragraph in the same section.

@Amila-Rukshan
Amila-Rukshan requested a review from a team as a code owner November 15, 2026 07:24
@google-cla

google-cla Bot commented Nov 15, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Remove a leftover sentence fragment that made the guidance on output only
values self-contradictory. Output only values related to the resource state
are covered by the later paragraph in the same section.

Signed-off-by: Amila Senadheera <amilaruk1995@gmail.com>
@Amila-Rukshan
Amila-Rukshan force-pushed the fix/aip-121-steady-state-wording branch from 9ead4c7 to fed961f Compare November 15, 2026 07:26

@noahdietz noahdietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing that up

@noahdietz

Copy link
Copy Markdown
Collaborator

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Please consider doing this so that your change can be accepted :)

@Amila-Rukshan

Copy link
Copy Markdown
Contributor Author

@noahdietz Thanks for the review! The CI workflows are now waiting for maintainer approval to run since I'm a first-time contributor. Could you approve them?

@noahdietz
noahdietz merged commit af48024 into aip-dev:master Nov 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants