Skip to content

fix: preserve array-valued casts when grouping columns - #548

Open
HocVoNgThai wants to merge 2 commits into
adaltas:masterfrom
HocVoNgThai:fix/group-array-cast-values
Open

HocVoNgThai wants to merge 2 commits into
adaltas:masterfrom
HocVoNgThai:fix/group-array-cast-values

Conversation

@HocVoNgThai

Copy link
Copy Markdown

Track which duplicate columns have been grouped instead of identifying groups by the value's type. Append later field values without flattening arrays.

For example, casting three duplicate columns to [1], [2] and [3] currently produces [1, 2, 3]. The change preserves the three values as [[1], [2], [3]], including empty arrays. Adds regressions for array-valued, mixed scalar/array and empty-array casts.

Closes #547

@wdavidw

wdavidw commented Nov 9, 2026

Copy link
Copy Markdown
Member

Thank you. Could you:

  1. Move the tests at the end of the TypeScript version (option.group_columns_by_name.ts)
  2. Remove the loop from the test and make sure every test illustrate something different

@HocVoNgThai

Copy link
Copy Markdown
Author

Thanks for the feedback. Updated as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Array-valued casts are flattened when grouping duplicate columns

2 participants